* [PATCH] netns: fix ip_rt_frag_needed rt_is_expired
@ 2008-07-26 12:48 Hugh Dickins
2008-07-26 16:37 ` Denis V. Lunev
0 siblings, 1 reply; 5+ messages in thread
From: Hugh Dickins @ 2008-07-26 12:48 UTC (permalink / raw)
To: David Miller
Cc: Denis V. Lunev, Andrew Morton, Ingo Molnar, netdev, linux-kernel
Running recent kernels, and using a particular vpn gateway, I've been
having to edit my mails down to get them accepted by the smtp server.
Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
netns: place rt_genid into struct net. The conversion from a != test
to rt_is_expired() put one negative too many: and now my mail works.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Ingo was having strange distcc problems, might this help him too?
net/ipv4/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 2.6.26-git/net/ipv4/route.c 2008-07-26 12:31:50.000000000 +0100
+++ linux/net/ipv4/route.c 2008-07-26 13:10:04.000000000 +0100
@@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct
rth->fl.iif != 0 ||
dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
!net_eq(dev_net(rth->u.dst.dev), net) ||
- !rt_is_expired(rth))
+ rt_is_expired(rth))
continue;
if (new_mtu < 68 || new_mtu >= old_mtu) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired
2008-07-26 12:48 [PATCH] netns: fix ip_rt_frag_needed rt_is_expired Hugh Dickins
@ 2008-07-26 16:37 ` Denis V. Lunev
2008-07-26 19:10 ` Denis V. Lunev
2008-07-27 0:51 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Denis V. Lunev @ 2008-07-26 16:37 UTC (permalink / raw)
To: Hugh Dickins
Cc: David Miller, Andrew Morton, Ingo Molnar, netdev, linux-kernel
Acked-by: Denis V. Lunev <den@openvz.org>
Thanks for founding this issue...
On Sat, 2008-07-26 at 13:48 +0100, Hugh Dickins wrote:
> Running recent kernels, and using a particular vpn gateway, I've been
> having to edit my mails down to get them accepted by the smtp server.
>
> Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
> netns: place rt_genid into struct net. The conversion from a != test
> to rt_is_expired() put one negative too many: and now my mail works.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Ingo was having strange distcc problems, might this help him too?
>
> net/ipv4/route.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 2.6.26-git/net/ipv4/route.c 2008-07-26 12:31:50.000000000 +0100
> +++ linux/net/ipv4/route.c 2008-07-26 13:10:04.000000000 +0100
> @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct
> rth->fl.iif != 0 ||
> dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
> !net_eq(dev_net(rth->u.dst.dev), net) ||
> - !rt_is_expired(rth))
> + rt_is_expired(rth))
> continue;
>
> if (new_mtu < 68 || new_mtu >= old_mtu) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired
2008-07-26 16:37 ` Denis V. Lunev
@ 2008-07-26 19:10 ` Denis V. Lunev
2008-07-26 19:26 ` Hugh Dickins
2008-07-27 0:51 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Denis V. Lunev @ 2008-07-26 19:10 UTC (permalink / raw)
To: Hugh Dickins
Cc: David Miller, Andrew Morton, Ingo Molnar, netdev, linux-kernel
On Sat, 2008-07-26 at 20:40 +0400, Denis V. Lunev wrote:
> Acked-by: Denis V. Lunev <den@openvz.org>
>
> Thanks for founding this issue...
oops... I mean finding and fixing... my fault again
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired
2008-07-26 16:37 ` Denis V. Lunev
2008-07-26 19:10 ` Denis V. Lunev
@ 2008-07-27 0:51 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2008-07-27 0:51 UTC (permalink / raw)
To: den; +Cc: hugh, akpm, mingo, netdev, linux-kernel
From: "Denis V. Lunev" <den@openvz.org>
Date: Sat, 26 Jul 2008 20:37:32 +0400
> Acked-by: Denis V. Lunev <den@openvz.org>
Applied, thanks a lot everyone.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-27 0:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-26 12:48 [PATCH] netns: fix ip_rt_frag_needed rt_is_expired Hugh Dickins
2008-07-26 16:37 ` Denis V. Lunev
2008-07-26 19:10 ` Denis V. Lunev
2008-07-26 19:26 ` Hugh Dickins
2008-07-27 0:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox