The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] hci_usb:replace mb with smp_mb
@ 2008-08-02  5:33 tom.leiming
  0 siblings, 0 replies; only message in thread
From: tom.leiming @ 2008-08-02  5:33 UTC (permalink / raw)
  To: marcel; +Cc: linux-bluetooth, linux-kernel, Ming Lei

From: Ming Lei <tom.leiming@gmail.com>

smp_mb is enough for ordering memory operations among processors,and
mb is more expensive than smp_mb for UP machine, so replace it with
smp_mb().

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 drivers/bluetooth/hci_usb.h |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/bluetooth/hci_usb.h b/drivers/bluetooth/hci_usb.h
index 1790cc8..8e65991 100644
--- a/drivers/bluetooth/hci_usb.h
+++ b/drivers/bluetooth/hci_usb.h
@@ -70,8 +70,8 @@ static inline void _urb_queue_head(struct _urb_queue *q, struct _urb *_urb)
 {
 	unsigned long flags;
 	spin_lock_irqsave(&q->lock, flags);
-	/* _urb_unlink needs to know which spinlock to use, thus mb(). */
-	_urb->queue = q; mb(); list_add(&_urb->list, &q->head);
+	/* _urb_unlink needs to know which spinlock to use, thus smp_mb(). */
+	_urb->queue = q; smp_mb(); list_add(&_urb->list, &q->head);
 	spin_unlock_irqrestore(&q->lock, flags);
 }
 
@@ -79,8 +79,8 @@ static inline void _urb_queue_tail(struct _urb_queue *q, struct _urb *_urb)
 {
 	unsigned long flags;
 	spin_lock_irqsave(&q->lock, flags);
-	/* _urb_unlink needs to know which spinlock to use, thus mb(). */
-	_urb->queue = q; mb(); list_add_tail(&_urb->list, &q->head);
+	/* _urb_unlink needs to know which spinlock to use, thus smp_mb(). */
+	_urb->queue = q; smp_mb(); list_add_tail(&_urb->list, &q->head);
 	spin_unlock_irqrestore(&q->lock, flags);
 }
 
@@ -89,7 +89,7 @@ static inline void _urb_unlink(struct _urb *_urb)
 	struct _urb_queue *q;
 	unsigned long flags;
 
-	mb();
+	smp_mb();
 	q = _urb->queue;
 	/* If q is NULL, it will die at easy-to-debug NULL pointer dereference.
 	   No need to BUG(). */
-- 
1.5.6.rc2.45.gdc92c


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-02  5:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-02  5:33 [PATCH] hci_usb:replace mb with smp_mb tom.leiming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox