public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [PATCH]: radeonfb: Fix copyarea for R300 and later.
Date: Thu, 07 Aug 2008 08:08:22 +1000	[thread overview]
Message-ID: <1218060502.24157.239.camel@pasglop> (raw)
In-Reply-To: <20080806.141920.30577822.davem@davemloft.net>

On Wed, 2008-08-06 at 14:19 -0700, David Miller wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 6 Aug 2008 08:43:29 -0700
> 
> > On Wed, 06 Aug 2008 00:35:36 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> > 
> > > [ Andrew/Ben, this fixes the bootup hang we were talking about
> > >   the other day. ]
> > > 
> > > radeonfb: Fix copyarea for R300 and later.
> > > 
> > > For current chips we need to make sure the DSTCACHE_CTLSTAT and
> > > WAIT_UNTIL registers are properly setup.  If not, a sequence of
> > > copyarea operations can result in the 2D raster processor
> > > hanging.
> > 
> > Neato.  This can be backported to -stable without also backporting your
> > recent radeon-misc-corrections.patch, I assume?
> 
> Yes, it can.
> 
> I discussed the patch with Ben earlier and he wants to add the
> same register writes to the solidfill code as well.

That and the flush code for when we're about to manually hit the fb.

I'll send a patch later today.

Ben.



  reply	other threads:[~2008-08-06 22:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-06  7:35 [PATCH]: radeonfb: Fix copyarea for R300 and later David Miller
2008-08-06 15:43 ` Andrew Morton
2008-08-06 21:19   ` David Miller
2008-08-06 22:08     ` Benjamin Herrenschmidt [this message]
2008-08-07  2:06     ` Benjamin Herrenschmidt
2008-08-07  5:52       ` Benjamin Herrenschmidt
2008-08-07 11:22         ` Geert Uytterhoeven
2008-08-07 21:24           ` Benjamin Herrenschmidt
2008-08-07  8:52     ` [PATCH] radeonfb: Fix engine hangs and cache flushing (v2) Benjamin Herrenschmidt
2008-08-06 22:09   ` [PATCH]: radeonfb: Fix copyarea for R300 and later Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218060502.24157.239.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox