From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Miller <davem@davemloft.net>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH]: radeonfb: Fix copyarea for R300 and later.
Date: Fri, 08 Aug 2008 07:24:26 +1000 [thread overview]
Message-ID: <1218144266.24157.300.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.0808071322080.23641@anakin>
On Thu, 2008-08-07 at 13:22 +0200, Geert Uytterhoeven wrote:
> Hi Ben,
>
> On Thu, 7 Aug 2008, Benjamin Herrenschmidt wrote:
> > > + /* Ensure the dst cache is flushed and the engine idle before
> > > + * issuing the operation.
> > > + *
> > > + * This works around engine lockups on some cards
> > > + */
> > > + OUTREG(DSTCACHE_CTLSTAT, RB2D_DC_FLUSH_ALL);
> > > + OUTREG(WAIT_UNTIL, (WAIT_2D_IDLECLEAN | WAIT_DMA_GUI_IDLE));
> > > +
> > > radeon_fifo_wait(2);
> >
> > Typo in the patch, missing radeon_fifo_wait before the cache flush.
> >
> > Fixed version on it's way, sorry.
>
> Can we please get a CC: linux-fbdev-devel on the fixed version?
I CCed the list on the final patch.
Ben.
next prev parent reply other threads:[~2008-08-07 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 7:35 [PATCH]: radeonfb: Fix copyarea for R300 and later David Miller
2008-08-06 15:43 ` Andrew Morton
2008-08-06 21:19 ` David Miller
2008-08-06 22:08 ` Benjamin Herrenschmidt
2008-08-07 2:06 ` Benjamin Herrenschmidt
2008-08-07 5:52 ` Benjamin Herrenschmidt
2008-08-07 11:22 ` Geert Uytterhoeven
2008-08-07 21:24 ` Benjamin Herrenschmidt [this message]
2008-08-07 8:52 ` [PATCH] radeonfb: Fix engine hangs and cache flushing (v2) Benjamin Herrenschmidt
2008-08-06 22:09 ` [PATCH]: radeonfb: Fix copyarea for R300 and later Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218144266.24157.300.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox