From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>,
mingo@elte.hu, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex
Date: Wed, 17 Sep 2008 13:46:42 -0700 [thread overview]
Message-ID: <1221684402.3077.15.camel@calx> (raw)
In-Reply-To: <20080917131419.e6b7622e.akpm@linux-foundation.org>
On Wed, 2008-09-17 at 13:14 -0700, Andrew Morton wrote:
> On Mon, 15 Sep 2008 00:12:31 +0200
> Nick Piggin <npiggin@suse.de> wrote:
>
> > tiny-shmem calls do_truncate in shmem_file_setup. do_truncate takes i_mutex,
> > and shmem_file_setup is called with mmap_sem held. However i_mutex nests
> > outside mmap_sem.
> >
> > Copy the code in shmem.c to avoid this problem.
> >
>
> It's a bit unfortunate (as in: arse-about) that we end up creating new
> files deep within the mmap code, but I guess we won't be changing that
> in a hurry.
Hugh and I talked about merging it back into one file ala the x86 32/64
merge. I've put it on my todo list.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-09-17 20:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 11:37 [patch] x86: some lock annotations for user copy paths Nick Piggin
2008-09-10 11:41 ` Peter Zijlstra
2008-09-10 11:47 ` Ingo Molnar
2008-09-10 11:50 ` Ingo Molnar
2008-09-10 12:12 ` Ingo Molnar
2008-09-10 12:32 ` Ingo Molnar
2008-09-10 15:12 ` Nick Piggin
2008-09-10 14:48 ` Nick Piggin
2008-09-10 15:01 ` Peter Zijlstra
2008-09-10 15:17 ` Nick Piggin
2008-09-10 15:26 ` Nick Piggin
2008-09-11 8:27 ` Ingo Molnar
2008-09-11 10:43 ` Nick Piggin
2008-09-12 9:24 ` [PATCH] sysfs: fix deadlock Ingo Molnar
2008-09-14 22:02 ` Nick Piggin
2008-09-15 9:15 ` Peter Zijlstra
2008-09-14 7:39 ` [lockdep] possible circular locking, between &mm->mmap_sem and &dev->ev_mutex Ingo Molnar
2008-09-14 7:44 ` Andrew Morton
2008-09-14 8:06 ` [patch] mm: fix locking, inotify_read's ev_mutex vs do_page_fault's mmap_sem Ingo Molnar
2008-09-14 22:12 ` [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex Nick Piggin
2008-09-17 20:14 ` Andrew Morton
2008-09-17 20:46 ` Matt Mackall [this message]
2008-09-18 11:12 ` Ingo Molnar
2008-09-18 19:29 ` Jeremy Fitzhardinge
2008-09-18 21:11 ` Matt Mackall
2008-09-20 2:18 ` Dave Hansen
2008-09-20 16:12 ` Hugh Dickins
2008-09-22 14:54 ` David Howells
2008-09-23 5:32 ` Nick Piggin
2008-09-24 18:18 ` David Howells
2008-09-24 18:29 ` Matt Mackall
2008-09-24 18:56 ` David Howells
2008-09-24 19:11 ` Matt Mackall
2008-09-24 19:26 ` David Howells
2008-09-24 19:41 ` Hugh Dickins
2008-09-24 19:59 ` David Howells
2008-09-24 23:43 ` Hugh Dickins
2008-09-24 19:29 ` Hugh Dickins
2008-09-24 19:47 ` Andrew Morton
2008-09-22 15:14 ` Dave Hansen
2008-09-19 8:40 ` Ingo Molnar
2008-09-14 21:36 ` [lockdep] possible circular locking, between &mm->mmap_sem and &dev->ev_mutex Nick Piggin
2008-09-10 14:30 ` [patch] x86: some lock annotations for user copy paths Nick Piggin
2008-09-10 14:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221684402.3077.15.camel@calx \
--to=mpm@selenic.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox