The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] arch/x86/events/intel/lbr.c - make variable static
@ 2019-08-08 17:28 Valdis Klētnieks
  0 siblings, 0 replies; only message in thread
From: Valdis Klētnieks @ 2019-08-08 17:28 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar; +Cc: x86, linux-kernel

When compiling with C=2, sparse warns:

  CHECK   arch/x86/events/intel/lbr.c
arch/x86/events/intel/lbr.c:276:1: warning: symbol 'lbr_from_quirk_key' was not declared. Should it be static?

And yes, it can be static.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
index 6f814a27416b..ea54634eabf3 100644
--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c
@@ -273,7 +273,7 @@ static inline bool lbr_from_signext_quirk_needed(void)
 	return !tsx_support && (lbr_desc[lbr_format] & LBR_TSX);
 }
 
-DEFINE_STATIC_KEY_FALSE(lbr_from_quirk_key);
+static DEFINE_STATIC_KEY_FALSE(lbr_from_quirk_key);
 
 /* If quirk is enabled, ensure sign extension is 63 bits: */
 inline u64 lbr_from_signext_quirk_wr(u64 val)


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-08 17:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-08 17:28 [PATCH] arch/x86/events/intel/lbr.c - make variable static Valdis Klētnieks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox