* [PATCH -tip] coda_psdev.h: extern's make no sense in userspace
@ 2009-01-13 6:36 Jaswinder Singh Rajput
2009-01-13 7:22 ` Harvey Harrison
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-01-13 6:36 UTC (permalink / raw)
To: Ingo Molnar, Alan Cox, sam, harvey.harrison, LKML, gorcunov
Impact: fix make headers_check warning:
usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
include/linux/coda_psdev.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
index 07ae8f8..c620958 100644
--- a/include/linux/coda_psdev.h
+++ b/include/linux/coda_psdev.h
@@ -87,6 +87,8 @@ struct upc_req {
* Statistics
*/
+#ifdef __KERNEL__
extern struct venus_comm coda_comms[];
+#endif /* __KERNEL__ */
#endif
--
1.5.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace
2009-01-13 6:36 [PATCH -tip] coda_psdev.h: extern's make no sense in userspace Jaswinder Singh Rajput
@ 2009-01-13 7:22 ` Harvey Harrison
0 siblings, 0 replies; 2+ messages in thread
From: Harvey Harrison @ 2009-01-13 7:22 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Ingo Molnar, Alan Cox, sam, LKML, gorcunov
On Tue, 2009-01-13 at 12:06 +0530, Jaswinder Singh Rajput wrote:
> Impact: fix make headers_check warning:
>
> usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> include/linux/coda_psdev.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
> index 07ae8f8..c620958 100644
> --- a/include/linux/coda_psdev.h
> +++ b/include/linux/coda_psdev.h
> @@ -87,6 +87,8 @@ struct upc_req {
> * Statistics
> */
>
> +#ifdef __KERNEL__
> extern struct venus_comm coda_comms[];
> +#endif /* __KERNEL__ */
As this only gets used in code/inode.c, coda/psdev.c it would be nice if
a code-internal header could be found that could hold this.
This is only here due to the one use outside of psdev.c in inode.c
Harvey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-13 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 6:36 [PATCH -tip] coda_psdev.h: extern's make no sense in userspace Jaswinder Singh Rajput
2009-01-13 7:22 ` Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox