The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jerome Glisse <glisse@freedesktop.org>
To: David Miller <davem@davemloft.net>
Cc: michel@daenzer.net, benh@kernel.crashing.org, airlied@linux.ie,
	dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: drm: radeon: Use surface for PCI GART table.
Date: Sat, 14 Feb 2009 12:35:11 +0100	[thread overview]
Message-ID: <1234611311.2860.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20090214.020431.193689843.davem@davemloft.net>

On Sat, 2009-02-14 at 02:04 -0800, David Miller wrote:
> From: Michel Dänzer <michel@daenzer.net>
> Date: Sat, 14 Feb 2009 10:59:59 +0100
> 
> > On Sat, 2009-02-14 at 01:51 -0800, David Miller wrote:
> > > This allocates a physical surface for the PCI GART table, this way no
> > > matter what other surface configurations exist the GART table will
> > > always be seen by the hardware properly.
> > 
> > BTW, I don't think the swapping settings affect GPU access to the table,
> > only CPU access, but this is a good solution anyway.
> 
> They absolutely and positively do effect GPU access to the table.
> I've proven it with many conclusive tests over the past 3 days.
> 
> > This is only really necessary on big endian, but other than that:
> > 
> > Acked-By: Michel Dänzer <daenzer@vmware.com>
> 
> Thanks.

This will need to be revisited with KMS as i think we should not allow
userspace to play with surface. Maybe we could setup surface on BO
mapping and disable them on bo unmapping (we would to register some
callback on vmclose).

Cheers,
Jerome Glisse


  reply	other threads:[~2009-02-14 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14  9:51 [PATCH]: drm: radeon: Use surface for PCI GART table David Miller
2009-02-14  9:59 ` Michel Dänzer
2009-02-14 10:04   ` David Miller
2009-02-14 11:35     ` Jerome Glisse [this message]
2009-02-14 11:41       ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234611311.2860.2.camel@localhost.localdomain \
    --to=glisse@freedesktop.org \
    --cc=airlied@linux.ie \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox