From: Jorg Schummer <ext-jorg.2.schummer@nokia.com>
To: linux-kernel@vger.kernel.org
Cc: drzeus-mmc@drzeus.cx, Jorg Schummer <ext-jorg.2.schummer@nokia.com>
Subject: [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in one run
Date: Thu, 19 Feb 2009 17:26:26 +0200 [thread overview]
Message-ID: <1235057186-31714-1-git-send-email-ext-jorg.2.schummer@nokia.com> (raw)
In-Reply-To: <>
With this patch, mmc_rescan can detect the removal of an mmc card and
the insertion of (possibly another) card in the same run. This means
that a card change can be detected without having to call
mmc_detect_change multiple times.
This change should generalise the core such that it can be easily used
by hosts which provide a mechanism to detect only the presence of a card
reader cover, which has to be taken off in order to insert a card. Other
hosts ("card detect" or "MMC_CAP_NEEDS_POLL") each receive an event when
a card is removed and when a card is inserted, so it is sufficient for
them if mmc_rescan handles only one event at a time. "Cover detect"
hosts, however, only receive events about the cover status. This means
that between 2 subsequent events, both a card removal and a card
insertion can occur. In this case, the current version of mmc_rescan
would only detect the removal of the previous card but not the insertion
of the new card.
This patch has been tested with the "cover detect" mechanism. If you
can, please test it with "card detect" and/or "polling" card readers.
Signed-off-by: Jorg Schummer <ext-jorg.2.schummer@nokia.com>
---
drivers/mmc/core/core.c | 22 +++++++++++++++++-----
1 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index df6ce4a..cd2e29f 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -740,6 +740,22 @@ void mmc_rescan(struct work_struct *work)
mmc_bus_get(host);
+ /* if there is a card registered */
+ if (host->bus_ops != NULL) {
+
+ if (host->bus_ops->detect && !host->bus_dead) {
+
+ /* check whether the card is still present */
+ host->bus_ops->detect(host);
+
+ /* release the bus and update bus status in case
+ the card was removed */
+ mmc_bus_put(host);
+ mmc_bus_get(host);
+ }
+ }
+
+ /* if there is no card registered */
if (host->bus_ops == NULL) {
/*
* Only we can add a new handler, so it's safe to
@@ -789,12 +805,8 @@ void mmc_rescan(struct work_struct *work)
mmc_release_host(host);
mmc_power_off(host);
- } else {
- if (host->bus_ops->detect && !host->bus_dead)
- host->bus_ops->detect(host);
-
+ } else
mmc_bus_put(host);
- }
out:
if (host->caps & MMC_CAP_NEEDS_POLL)
mmc_schedule_delayed_work(&host->detect, HZ);
--
1.5.4.3
next reply other threads:[~2009-02-19 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 15:26 Jorg Schummer [this message]
2009-03-02 20:09 ` [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in one run Pierre Ossman
2009-03-03 7:24 ` Jörg Schummer
2009-03-03 8:55 ` Pierre Ossman
2009-03-31 14:51 ` [PATCH 1/1] " Jorg Schummer
2009-04-10 16:39 ` Pierre Ossman
2009-06-03 9:47 ` Jörg Schummer
2009-06-03 10:24 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235057186-31714-1-git-send-email-ext-jorg.2.schummer@nokia.com \
--to=ext-jorg.2.schummer@nokia.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox