From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: "Jörg Schummer" <ext-jorg.2.schummer@nokia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in one run
Date: Tue, 3 Mar 2009 09:55:30 +0100 [thread overview]
Message-ID: <20090303095530.65923117@mjolnir.ossman.eu> (raw)
In-Reply-To: <1236065059.5791.34.camel@jorg-desktop>
On Tue, 03 Mar 2009 09:24:19 +0200
Jörg Schummer <ext-jorg.2.schummer@nokia.com> wrote:
> >
> > The else section got a bit small here with that code removed. Perhaps
> > we should instead have:
> >
> > if (host->bus_ops != NULL) {
> > mmc_bus_put(host);
> > goto out;
> > }
>
> I guess you meant
>
> else {
> mmc_bus_put(host);
> goto out;
> }
>
> since it would be the else clause of
>
> if (host->bus_ops == NULL)
>
No, I meant to put it further up and unindent the detection code.
Basically you'll be reversing the if-else blocks, but using a goto
instead of an else.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
next prev parent reply other threads:[~2009-03-03 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 15:26 [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in one run Jorg Schummer
2009-03-02 20:09 ` Pierre Ossman
2009-03-03 7:24 ` Jörg Schummer
2009-03-03 8:55 ` Pierre Ossman [this message]
2009-03-31 14:51 ` [PATCH 1/1] " Jorg Schummer
2009-04-10 16:39 ` Pierre Ossman
2009-06-03 9:47 ` Jörg Schummer
2009-06-03 10:24 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303095530.65923117@mjolnir.ossman.eu \
--to=drzeus-mmc@drzeus.cx \
--cc=ext-jorg.2.schummer@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox