From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] slub: add min_partial sysfs tunable
Date: Mon, 23 Feb 2009 10:19:22 +0200 [thread overview]
Message-ID: <1235377162.6216.5.camel@penberg-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.0902221712160.26165@chino.kir.corp.google.com>
Hi David,
On Sun, 2009-02-22 at 17:40 -0800, David Rientjes wrote:
> Now that a cache's min_partial has been moved to struct kmem_cache, it's
> possible to easily tune it from userspace by adding a sysfs attribute.
>
> It may not be desirable to keep a large number of partial slabs around if
> a cache is used infrequently and memory, especially when constrained by a
> cgroup, is scarce. It's better to allow userspace to set the minimum
> policy per cache instead of relying explicitly on kmem_cache_shrink().
The patches look good but the description is bit lacking. Does this
actually fix up something? Why don't we fix the limit calculations
instead?
I'm a sucker for numbers so I'm easily fooled into merging patches with
statements of the form "this shaves off N bytes/kb/mb on XYZ systems".
Pekka
next prev parent reply other threads:[~2009-02-23 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 1:40 [patch 1/2] slub: move min_partial to struct kmem_cache David Rientjes
2009-02-23 1:40 ` [patch 2/2] slub: add min_partial sysfs tunable David Rientjes
2009-02-23 8:19 ` Pekka Enberg [this message]
2009-02-23 9:58 ` David Rientjes
2009-02-23 10:26 ` Pekka Enberg
2009-02-23 16:11 ` Christoph Lameter
2009-02-23 16:09 ` [patch 1/2] slub: move min_partial to struct kmem_cache Christoph Lameter
2009-02-23 16:23 ` David Rientjes
2009-02-23 16:20 ` [patch 1/2] slub: move min_partial to struct kmem_cach Christoph Lameter
2009-02-23 16:37 ` David Rientjes
2009-02-25 7:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235377162.6216.5.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox