From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] slub: move min_partial to struct kmem_cach
Date: Wed, 25 Feb 2009 09:17:46 +0200 [thread overview]
Message-ID: <1235546266.6216.71.camel@penberg-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.0902230835120.24379@chino.kir.corp.google.com>
On Mon, 23 Feb 2009, Christoph Lameter wrote:
> > > The second patch in this series as a /sys/kernel/slab/cache/min_partial
> > > tunable that uses calculate_min_partial() to enforce a sane range, so
> > > while it may not actually be doing any calculations, the ilog2() is
> > > appropriately placed in kmem_cache_open(). We don't want to be taking the
> > > log of the user's min_partial value.
> >
> > Then Rename the function to set_min_partial()?
On Mon, 2009-02-23 at 08:37 -0800, David Rientjes wrote:
> I don't have any strong opinions as to the specific name, so I'll leave
> this up to Pekka. set_min_partial(), to me, seems to indicate that
> s->min_partial will unconditionally set to the value passed, which isn't
> necessarily true.
Applied, thanks!
prev parent reply other threads:[~2009-02-25 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 1:40 [patch 1/2] slub: move min_partial to struct kmem_cache David Rientjes
2009-02-23 1:40 ` [patch 2/2] slub: add min_partial sysfs tunable David Rientjes
2009-02-23 8:19 ` Pekka Enberg
2009-02-23 9:58 ` David Rientjes
2009-02-23 10:26 ` Pekka Enberg
2009-02-23 16:11 ` Christoph Lameter
2009-02-23 16:09 ` [patch 1/2] slub: move min_partial to struct kmem_cache Christoph Lameter
2009-02-23 16:23 ` David Rientjes
2009-02-23 16:20 ` [patch 1/2] slub: move min_partial to struct kmem_cach Christoph Lameter
2009-02-23 16:37 ` David Rientjes
2009-02-25 7:17 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235546266.6216.71.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox