From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -tip] x86: apic/apic.c default_init_apic_ldr() is required only for X86_32
Date: Thu, 14 May 2009 14:19:12 +0530 [thread overview]
Message-ID: <1242290952.3178.1.camel@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0905140952220.3561@localhost.localdomain>
On Thu, 2009-05-14 at 09:53 +0200, Thomas Gleixner wrote:
> On Thu, 14 May 2009, Jaswinder Singh Rajput wrote:
> >
> > default_init_apic_ldr() is also required for 64 bit so moving it out
> > from CONFIG_X86_32.
>
> [linux-2.6-tip]$ git grep default_init_apic_ldr arch/x86/
> arch/x86/include/asm/apic.h:extern void default_init_apic_ldr(void);
> arch/x86/kernel/apic/apic.c:void default_init_apic_ldr(void)
> arch/x86/kernel/apic/probe_32.c: .init_apic_ldr = default_init_apic_ldr,
>
> I have a hard time to see how 64bit requires that function.
>
Here is new patch to make you easy :-)
[PATCH] x86: apic/apic.c default_init_apic_ldr() is required only for X86_32
default_init_apic_ldr() is used only by X86_32.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/apic/apic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index d6d4ffd..6ae5303 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1941,6 +1941,7 @@ int hard_smp_processor_id(void)
return read_apic_id();
}
+#ifdef CONFIG_X86_32
void default_init_apic_ldr(void)
{
unsigned long val;
@@ -1951,7 +1952,6 @@ void default_init_apic_ldr(void)
apic_write(APIC_LDR, val);
}
-#ifdef CONFIG_X86_32
int default_apicid_to_node(int logical_apicid)
{
#ifdef CONFIG_SMP
--
1.6.0.6
next prev parent reply other threads:[~2009-05-14 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 21:57 [PATCH 1/2] x86: apic/apic.c declare default_init_apic_ldr() before it get used Jaswinder Singh Rajput
2009-05-13 21:59 ` [PATCH 2/2] x86: apic/apic.c native_apic_write_dummy() should be static Jaswinder Singh Rajput
2009-05-14 3:04 ` Cyrill Gorcunov
2009-05-14 7:53 ` [PATCH 1/2] x86: apic/apic.c declare default_init_apic_ldr() before it get used Thomas Gleixner
2009-05-14 8:49 ` Jaswinder Singh Rajput [this message]
2009-05-14 9:24 ` [PATCH -tip] x86: apic/apic.c default_init_apic_ldr() is required only for X86_32 Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242290952.3178.1.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox