public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86: apic/apic.c declare default_init_apic_ldr() before it get used
Date: Thu, 14 May 2009 09:53:44 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0905140952220.3561@localhost.localdomain> (raw)
In-Reply-To: <1242251841.3364.17.camel@localhost.localdomain>

On Thu, 14 May 2009, Jaswinder Singh Rajput wrote:
> 
> default_init_apic_ldr() is also required for 64 bit so moving it out
> from CONFIG_X86_32.

[linux-2.6-tip]$ git grep default_init_apic_ldr arch/x86/
arch/x86/include/asm/apic.h:extern void default_init_apic_ldr(void);
arch/x86/kernel/apic/apic.c:void default_init_apic_ldr(void)
arch/x86/kernel/apic/probe_32.c:        .init_apic_ldr                  = default_init_apic_ldr,

I have a hard time to see how 64bit requires that function.

Thanks,

	tglx

  parent reply	other threads:[~2009-05-14  7:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 21:57 [PATCH 1/2] x86: apic/apic.c declare default_init_apic_ldr() before it get used Jaswinder Singh Rajput
2009-05-13 21:59 ` [PATCH 2/2] x86: apic/apic.c native_apic_write_dummy() should be static Jaswinder Singh Rajput
2009-05-14  3:04   ` Cyrill Gorcunov
2009-05-14  7:53 ` Thomas Gleixner [this message]
2009-05-14  8:49   ` [PATCH -tip] x86: apic/apic.c default_init_apic_ldr() is required only for X86_32 Jaswinder Singh Rajput
2009-05-14  9:24     ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0905140952220.3561@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox