* [PATCH] perf_counter: do not create perf counter mlock sysctl when CONFIG_PERF_COUNTERS=n
@ 2009-05-22 9:42 Ian Campbell
2009-05-22 19:25 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2009-05-22 9:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Zijlstra, Paul Mackerras, Corey Ashford, Ingo Molnar
Building tip from 82811bee3 without CONFIG_PERF_COUNTERS results in:
CC kernel/sysctl.o
kernel/sysctl.c:928: error: 'sysctl_perf_counter_mlock' undeclared here (not in a function)
This is due to c5078f78b "perf_counter: provide an mlock threshold"
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 44ebd90..c2a4467 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -922,6 +922,7 @@ static struct ctl_table kern_table[] = {
.child = slow_work_sysctls,
},
#endif
+#ifdef CONFIG_PERF_COUNTERS
{
.ctl_name = CTL_UNNUMBERED,
.procname = "perf_counter_mlock_kb",
@@ -930,6 +931,7 @@ static struct ctl_table kern_table[] = {
.mode = 0644,
.proc_handler = &proc_dointvec,
},
+#endif
/*
* NOTE: do not add new entries to this table unless you have read
* Documentation/sysctl/ctl_unnumbered.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf_counter: do not create perf counter mlock sysctl when CONFIG_PERF_COUNTERS=n
2009-05-22 9:42 [PATCH] perf_counter: do not create perf counter mlock sysctl when CONFIG_PERF_COUNTERS=n Ian Campbell
@ 2009-05-22 19:25 ` Ingo Molnar
2009-05-24 8:25 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-05-22 19:25 UTC (permalink / raw)
To: Ian Campbell; +Cc: linux-kernel, Peter Zijlstra, Paul Mackerras, Corey Ashford
* Ian Campbell <Ian.Campbell@citrix.com> wrote:
> Building tip from 82811bee3 without CONFIG_PERF_COUNTERS results in:
>
> CC kernel/sysctl.o
> kernel/sysctl.c:928: error: 'sysctl_perf_counter_mlock' undeclared here (not in a function)
>
> This is due to c5078f78b "perf_counter: provide an mlock threshold"
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 44ebd90..c2a4467 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -922,6 +922,7 @@ static struct ctl_table kern_table[] = {
> .child = slow_work_sysctls,
> },
> #endif
> +#ifdef CONFIG_PERF_COUNTERS
> {
> .ctl_name = CTL_UNNUMBERED,
> .procname = "perf_counter_mlock_kb",
> @@ -930,6 +931,7 @@ static struct ctl_table kern_table[] = {
> .mode = 0644,
> .proc_handler = &proc_dointvec,
> },
> +#endif
> /*
> * NOTE: do not add new entries to this table unless you have read
> * Documentation/sysctl/ctl_unnumbered.txt
Hm, is this still needed? It doesnt apply here and i'm not seeing
build failures.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf_counter: do not create perf counter mlock sysctl when CONFIG_PERF_COUNTERS=n
2009-05-22 19:25 ` Ingo Molnar
@ 2009-05-24 8:25 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2009-05-24 8:25 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Peter Zijlstra, Paul Mackerras, Corey Ashford
On Fri, 2009-05-22 at 15:25 -0400, Ingo Molnar wrote:
> * Ian Campbell <Ian.Campbell@citrix.com> wrote:
>
> > Building tip from 82811bee3 without CONFIG_PERF_COUNTERS results in:
> >
> > CC kernel/sysctl.o
> > kernel/sysctl.c:928: error: 'sysctl_perf_counter_mlock' undeclared here (not in a function)
> Hm, is this still needed? It doesnt apply here and i'm not seeing
> build failures.
Looks like I was using an obsolete branch, on current tip (790dc57b) it
was already fixed by the commit which added the first perf counter
sysctl in 1ccd1549.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-24 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-22 9:42 [PATCH] perf_counter: do not create perf counter mlock sysctl when CONFIG_PERF_COUNTERS=n Ian Campbell
2009-05-22 19:25 ` Ingo Molnar
2009-05-24 8:25 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox