From: Matt Mackall <mpm@selenic.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH] TXx9: Add TX4939 RNG support
Date: Sun, 31 May 2009 12:32:50 -0500 [thread overview]
Message-ID: <1243791170.22069.28.camel@calx> (raw)
In-Reply-To: <20090601.022335.200392387.anemo@mba.ocn.ne.jp>
On Mon, 2009-06-01 at 02:23 +0900, Atsushi Nemoto wrote:
> On Sun, 31 May 2009 12:01:29 -0500, Matt Mackall <mpm@selenic.com> wrote:
> > > > Not clear to me how this works when this is a module?
> > >
> > > This patch add a registration of a platform device for RNG to vmlinux.
> > > And the other patch add a driver module for the RNG. This strategy is
> > > fairly common for SoCs or embedded platforms.
> >
> > If your driver is built as a module (which your patch allows), the above
> > won't work, right?
>
> No, the rng driver can be used regardless of module or built-in, as
> like as other platform drivers. Any special issue for hw_rng?
I found the source of my confusion: you've given the init function in
both files exactly the same name. So when I saw .._init at the bottom of
the second patch, I assumed it was referring to the possibly not loaded
driver's init code.
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2009-05-31 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 15:02 [PATCH] TXx9: Add TX4939 RNG support Atsushi Nemoto
[not found] ` <1243642882.8020.9.camel@calx>
2009-05-31 16:57 ` Atsushi Nemoto
2009-05-31 17:01 ` Matt Mackall
2009-05-31 17:23 ` Atsushi Nemoto
2009-05-31 17:32 ` Matt Mackall [this message]
2009-06-02 14:13 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243791170.22069.28.camel@calx \
--to=mpm@selenic.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox