From: "Steven J. Magnani" <steve@digidescorp.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FAT: optimize FSINFO writeback
Date: Tue, 30 Jun 2009 17:19:05 -0500 [thread overview]
Message-ID: <1246400345.2247.4.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <87ocs5h238.fsf@devron.myhome.or.jp>
On Wed, 2009-07-01 at 05:57 +0900, OGAWA Hirofumi wrote:
> steve@digidescorp.com writes:
>
> > Only write the FSINFO block back to disk when its contents change.
> > This optimization can be important when the underlying physical media
> > can wear out, i.e. Flash.
>
> I have no objection to this though. Was this tested on recent version?
I tested it on 2.6.30.
> Well, now, we are using sb->s_dirty for fsinfo, so I'm wondering why
> this happen frequently.
My scenario was modifying a sector of an existing file and using
fdatasync() to flush it. The FSINFO sector was being updated even though
nothing about the FAT layout had changed.
>
> Thanks.
Regards,
------------------------------------------------------------------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
next prev parent reply other threads:[~2009-06-30 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 20:02 [PATCH] FAT: optimize FSINFO writeback steve
2009-06-30 20:57 ` OGAWA Hirofumi
2009-06-30 22:19 ` Steven J. Magnani [this message]
2009-07-01 0:28 ` OGAWA Hirofumi
2009-07-01 13:07 ` Steven J. Magnani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246400345.2247.4.camel@iscandar.digidescorp.com \
--to=steve@digidescorp.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox