public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: steve@digidescorp.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FAT: optimize FSINFO writeback
Date: Wed, 01 Jul 2009 09:28:20 +0900	[thread overview]
Message-ID: <873a9hfdqz.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1246400345.2247.4.camel@iscandar.digidescorp.com> (Steven J. Magnani's message of "Tue, 30 Jun 2009 17:19:05 -0500")

"Steven J. Magnani" <steve@digidescorp.com> writes:

>> Well, now, we are using sb->s_dirty for fsinfo, so I'm wondering why
>> this happen frequently.
>
> My scenario was modifying a sector of an existing file and using
> fdatasync() to flush it. The FSINFO sector was being updated even though
> nothing about the FAT layout had changed.

I see. Probably, I'm missing something, or handling of sb->s_dirt may be
buggy, or something.

If it was fixed, is this patch still needed?  I guess this patch would
still be useful on some case though.  If you can explain, it would be
good.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2009-07-01  0:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 20:02 [PATCH] FAT: optimize FSINFO writeback steve
2009-06-30 20:57 ` OGAWA Hirofumi
2009-06-30 22:19   ` Steven J. Magnani
2009-07-01  0:28     ` OGAWA Hirofumi [this message]
2009-07-01 13:07       ` Steven J. Magnani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873a9hfdqz.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steve@digidescorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox