public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Michael Witten <mfwitten@gmail.com>,
	Johannes Stezenbach <js@sig21.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.30: hibernation/swsusp lockup due to acpi-cpufreq
Date: Mon, 06 Jul 2009 14:20:30 -0700	[thread overview]
Message-ID: <1246915230.11545.61.camel@localhost.localdomain> (raw)
In-Reply-To: <200907042329.04926.rjw@sisk.pl>

On Sat, 2009-07-04 at 14:29 -0700, Rafael J. Wysocki wrote:
> On Saturday 04 July 2009, Michael Witten wrote:
> > On Tue, 16 Jun 2009 23:39:59 +0200, Rafael J. Wysocki wrote
> > (http://www.spinics.net/lists/linux-acpi/msg22661.html):
> > 
> > > In fact, we need to do this entire thing differently.
> > > 
> > > The basic problem is that cpufreq_suspend() is a sysdev thing, so it will 
> > > always be called with iterrupts off and *only* for CPU0.  So, it looks like
> > > the majority of things we do there is just unnecessary (at least).
> > 
> > What's the status? This bug is driving me nuts.
> 
> Unfortunately, still unresolved.

Looked at this a bit more from acpi cpufreq angle.

But, I feel the patch that Johannes had here
http://lkml.indiana.edu/hypermail/linux/kernel/0906.2/00335.html
is the right fix as we do the same saving and restoring of flags on SMP
when cpu==this_cpu. This change will make code in UP same as that in SMP
with 1 CPU active.

We can avoid the driver->get call from cpufreq_suspend for the drivers
that do not do any freq changes in their suspend methods. But, then we
will hit this same problem in cpufreq_resume() path and there we do want
to check for adjust_jiffies for all drivers as long as CONSTANT_LOOPS is
not set.

Thanks,
Venki


  reply	other threads:[~2009-07-06 21:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cNtMS-6Iq-11@gated-at.bofh.it>
     [not found] ` <cNuzd-7VN-3@gated-at.bofh.it>
     [not found]   ` <cNHPT-3kB-1@gated-at.bofh.it>
     [not found]     ` <cNM3f-1ty-29@gated-at.bofh.it>
     [not found]       ` <cNMZg-2ZR-17@gated-at.bofh.it>
     [not found]         ` <cNNsg-3U5-3@gated-at.bofh.it>
     [not found]           ` <cNNLx-4kf-5@gated-at.bofh.it>
     [not found]             ` <cNOeG-5cB-23@gated-at.bofh.it>
     [not found]               ` <cNOok-5pJ-11@gated-at.bofh.it>
     [not found]                 ` <cNOy0-5C5-23@gated-at.bofh.it>
2009-07-04 18:09                   ` 2.6.30: hibernation/swsusp lockup due to acpi-cpufreq Michael Witten
2009-07-04 21:29                     ` Rafael J. Wysocki
2009-07-06 21:20                       ` Pallipadi, Venkatesh [this message]
2009-07-06 21:39                         ` Rafael J. Wysocki
2009-07-06 22:16                           ` Pallipadi, Venkatesh
2009-06-15 23:27 Johannes Stezenbach
2009-06-16  0:16 ` Rafael J. Wysocki
2009-06-16 14:22   ` Johannes Stezenbach
2009-06-16 18:55     ` Andrew Morton
2009-06-16 19:57       ` Johannes Stezenbach
2009-06-16 20:25         ` Pallipadi, Venkatesh
2009-06-16 20:40           ` Johannes Stezenbach
2009-06-16 21:09             ` Andrew Morton
2009-06-16 21:18               ` Pallipadi, Venkatesh
2009-06-16 21:39                 ` Rafael J. Wysocki
2009-06-16 22:44               ` Johannes Stezenbach
2009-06-16 20:44           ` Johannes Stezenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246915230.11545.61.camel@localhost.localdomain \
    --to=venkatesh.pallipadi@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=js@sig21.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfwitten@gmail.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox