From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
Balbir Singh <balbir@in.ibm.com>
Subject: Re: [PATCH v4 2/5] sched: Record the current active power savings level
Date: Mon, 24 Aug 2009 18:09:25 +0200 [thread overview]
Message-ID: <1251130165.7538.311.camel@twins> (raw)
In-Reply-To: <20090331105022.16414.4304.stgit@sofia.in.ibm.com>
On Tue, 2009-03-31 at 16:20 +0530, Gautham R Shenoy wrote:
> The existing load balancer code is dependent on the sched_mc_power_savings
> variable. However, on multi-core + multi-threaded machines, these decisions
> need to be dependent on the values of both sched_mc_power_savings and
> sched_smt_power_savings.
>
> Create a new variable named active_power_savings_level which is the
> maximum of the sched_mc_power_savings and sched_smt_power_savings.
>
> Record this value in a read mostly global variable at the time when the user
> changes the value of sched_mc/smt_power_savings tunable, and use it for
> load-balancing decisions instead of computing it everytime.
OK, so why keep these variables separate at all?
next prev parent reply other threads:[~2009-08-24 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 10:50 [PATCH v4 0/5] sched: Extend sched_mc/smt_power_savings framework Gautham R Shenoy
2009-03-31 10:50 ` [PATCH v4 1/5] sched: code cleanup - sd_power_saving_flags(), sd_balance_for_*_power() Gautham R Shenoy
2009-03-31 10:50 ` [PATCH v4 2/5] sched: Record the current active power savings level Gautham R Shenoy
2009-08-24 16:09 ` Peter Zijlstra [this message]
2009-08-25 9:12 ` Gautham R Shenoy
2009-03-31 10:50 ` [PATCH v4 3/5] sched: Rename the variable sched_mc_preferred_wakeup_cpu Gautham R Shenoy
2009-03-31 10:50 ` [PATCH v4 4/5] sched: Arbitrate the nomination of preferred_wakeup_cpu Gautham R Shenoy
2009-03-31 10:50 ` [PATCH v4 5/5] sched: Fix sd_parent_degenerate for SD_POWERSAVINGS_BALANCE Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251130165.7538.311.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=balbir@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox