* [GIT-PULL] includecheck fixes
@ 2009-09-20 11:52 Jaswinder Singh Rajput
0 siblings, 0 replies; 9+ messages in thread
From: Jaswinder Singh Rajput @ 2009-09-20 11:52 UTC (permalink / raw)
To: Linus Torvalds, LKML
Linus,
Please pull includecheck fixes.
The following changes since commit 78f28b7c555359c67c2a0d23f7436e915329421e:
Linus Torvalds (1):
Merge branch 'x86-platform-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6.git master
Jaswinder Singh Rajput (15):
includecheck fix: s390, sys_s390.c
includecheck fix: um, helper.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c
includecheck fix: drivers/video, vgacon.c
includecheck fix: drivers/xen, evtchn.c
includecheck fix: include/acpi, acpi_bus.h
includecheck fix: include/drm, drm_memory.h
includecheck fix: include/linux, aio.h
includecheck fix: include/linux, page_cgroup.h
includecheck fix: include/linux, ftrace.h
includecheck fix: kernel/trace, ring_buffer.c
includecheck fix: x86, cpu/common.c
arch/s390/kernel/sys_s390.c | 1 -
arch/um/os-Linux/helper.c | 1 -
arch/x86/kernel/cpu/common.c | 1 -
arch/x86/kernel/traps.c | 1 -
arch/x86/mm/kmemcheck/shadow.c | 1 -
drivers/scsi/fcoe/libfcoe.c | 1 -
drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
drivers/video/console/vgacon.c | 1 -
drivers/xen/evtchn.c | 1 -
include/acpi/acpi_bus.h | 1 -
include/drm/drm_memory.h | 2 --
include/linux/aio.h | 2 --
include/linux/ftrace.h | 1 -
include/linux/page_cgroup.h | 4 ++--
kernel/trace/ring_buffer.c | 2 --
15 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/arch/s390/kernel/sys_s390.c b/arch/s390/kernel/sys_s390.c
index c7ae4b1..e9d94f6 100644
--- a/arch/s390/kernel/sys_s390.c
+++ b/arch/s390/kernel/sys_s390.c
@@ -29,7 +29,6 @@
#include <linux/personality.h>
#include <linux/unistd.h>
#include <linux/ipc.h>
-#include <linux/syscalls.h>
#include <asm/uaccess.h>
#include "entry.h"
diff --git a/arch/um/os-Linux/helper.c b/arch/um/os-Linux/helper.c
index 30860b8..b6b1096 100644
--- a/arch/um/os-Linux/helper.c
+++ b/arch/um/os-Linux/helper.c
@@ -15,7 +15,6 @@
#include "os.h"
#include "um_malloc.h"
#include "user.h"
-#include <linux/limits.h>
struct helper_data {
void (*pre_exec)(void*);
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 2055fc2..2fea97e 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -34,7 +34,6 @@
#include <asm/mce.h>
#include <asm/msr.h>
#include <asm/pat.h>
-#include <linux/smp.h>
#ifdef CONFIG_X86_LOCAL_APIC
#include <asm/uv/uv.h>
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 7dc0de9..9346e10 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -65,7 +65,6 @@
#else
#include <asm/processor-flags.h>
#include <asm/setup.h>
-#include <asm/traps.h>
asmlinkage int system_call(void);
diff --git a/arch/x86/mm/kmemcheck/shadow.c b/arch/x86/mm/kmemcheck/shadow.c
index e773b6b..3f66b82 100644
--- a/arch/x86/mm/kmemcheck/shadow.c
+++ b/arch/x86/mm/kmemcheck/shadow.c
@@ -1,7 +1,6 @@
#include <linux/kmemcheck.h>
#include <linux/module.h>
#include <linux/mm.h>
-#include <linux/module.h>
#include <asm/page.h>
#include <asm/pgtable.h>
diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
index 62a4c20..11ae5c9 100644
--- a/drivers/scsi/fcoe/libfcoe.c
+++ b/drivers/scsi/fcoe/libfcoe.c
@@ -29,7 +29,6 @@
#include <linux/ethtool.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
-#include <linux/netdevice.h>
#include <linux/errno.h>
#include <linux/bitops.h>
#include <net/rtnetlink.h>
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 9928704..d9b0e9d 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -73,7 +73,6 @@
#include <linux/of.h>
#include <asm/firmware.h>
#include <asm/vio.h>
-#include <asm/firmware.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_host.h>
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index 59d7d5e..74e96cf 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -180,7 +180,6 @@ static inline void vga_set_mem_top(struct vc_data *c)
}
#ifdef CONFIG_VGACON_SOFT_SCROLLBACK
-#include <linux/slab.h>
/* software scrollback */
static void *vgacon_scrollback;
static int vgacon_scrollback_tail;
diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
index af03195..79bedba 100644
--- a/drivers/xen/evtchn.c
+++ b/drivers/xen/evtchn.c
@@ -38,7 +38,6 @@
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/fs.h>
-#include <linux/errno.h>
#include <linux/miscdevice.h>
#include <linux/major.h>
#include <linux/proc_fs.h>
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index 1fa3ffb..1b3b360 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -356,7 +356,6 @@ void acpi_remove_dir(struct acpi_device *);
/*
* Bind physical devices with ACPI devices
*/
-#include <linux/device.h>
struct acpi_bus_type {
struct list_head list;
struct bus_type *bus;
diff --git a/include/drm/drm_memory.h b/include/drm/drm_memory.h
index 63e425b..15af9b3 100644
--- a/include/drm/drm_memory.h
+++ b/include/drm/drm_memory.h
@@ -44,8 +44,6 @@
#if __OS_HAS_AGP
-#include <linux/vmalloc.h>
-
#ifdef HAVE_PAGE_AGP
#include <asm/agp.h>
#else
diff --git a/include/linux/aio.h b/include/linux/aio.h
index 47f7d93..aea219d 100644
--- a/include/linux/aio.h
+++ b/include/linux/aio.h
@@ -225,8 +225,6 @@ static inline void exit_aio(struct mm_struct *mm) { }
#define io_wait_to_kiocb(wait) container_of(wait, struct kiocb, ki_wait)
-#include <linux/aio_abi.h>
-
static inline struct kiocb *list_kiocb(struct list_head *h)
{
return list_entry(h, struct kiocb, ki_list);
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index dc3b132..3c0924a 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -446,7 +446,6 @@ static inline void unpause_graph_tracing(void) { }
#endif /* CONFIG_FUNCTION_GRAPH_TRACER */
#ifdef CONFIG_TRACING
-#include <linux/sched.h>
/* flags for current->trace */
enum {
diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h
index 13f126c..ada779f 100644
--- a/include/linux/page_cgroup.h
+++ b/include/linux/page_cgroup.h
@@ -105,14 +105,14 @@ static inline void __init page_cgroup_init_flatmem(void)
#endif
-#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP
#include <linux/swap.h>
+
+#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP
extern unsigned short swap_cgroup_record(swp_entry_t ent, unsigned short id);
extern unsigned short lookup_swap_cgroup(swp_entry_t ent);
extern int swap_cgroup_swapon(int type, unsigned long max_pages);
extern void swap_cgroup_swapoff(int type);
#else
-#include <linux/swap.h>
static inline
unsigned short swap_cgroup_record(swp_entry_t ent, unsigned short id)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 6eef389..d4ff019 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -201,8 +201,6 @@ int tracing_is_on(void)
}
EXPORT_SYMBOL_GPL(tracing_is_on);
-#include "trace.h"
-
#define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array))
#define RB_ALIGNMENT 4U
#define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX)
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 0/44] includecheck: fix multiple includes
@ 2009-07-08 14:28 Jaswinder Singh Rajput
2009-07-09 18:40 ` [GIT-PULL] includecheck fixes Jaswinder Singh Rajput
0 siblings, 1 reply; 9+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-08 14:28 UTC (permalink / raw)
To: Russell King, Kevin Hilman, David Howells, benh, paulus,
schwidefsky, heiko.carstens, jdike, Ingo Molnar, x86 maintainers,
Alan Cox, David Miller, James Bottomley, dbrownell, Greg KH,
mchehab, jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML
The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
Linus Torvalds (1):
Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master
Jaswinder Singh Rajput (44):
includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c
includecheck fix: arm, board-dm355-leopard.c
includecheck fix: arm, board-dm644x-evm.c
includecheck fix: arm, board-dm646x-evm.c
includecheck fix: arm, board-sffsdr.c
includecheck fix: arm, mach-mx3/devices.c
includecheck fix: arm, mach-omap1/mcbsp.c
includecheck fix: arm, mach-omap2/mcbsp.c
includecheck fix: arm, plat-s3c64xx/pm.c
includecheck fix: arm, plat-stmp3xxx/pinmux.c
includecheck fix: mn10300, sys_mn10300.c
includecheck fix: powerpc, mpc7450-pmu.c
includecheck fix: powerpc, ppc970-pmu.c
includecheck fix: s390, sys_s390.c
includecheck fix: um, helper.c
includecheck fix: x86, dumpstack.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: Documentation, cfag12864b-example.c
includecheck fix: drivers/char, vt.c
includecheck fix: drivers/net, sja1000.c
includecheck fix: drivers/net, axnet_cs.c
includecheck fix: drivers/net, smc911x.h
includecheck fix: drivers/parisc, ccio-dma.c
includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c
includecheck fix: drivers/spi, amba-pl022.c
includecheck fix: drivers/staging, usbdrv.c
includecheck fix: drivers/staging, rt_linux.h
includecheck fix: drivers/video, vgacon.c
includecheck fix: drivers/xen, evtchn.c
includecheck fix: fs/xfs, xfs_iops.c
includecheck fix: include/acpi, acpi_bus.h
includecheck fix: include/drm, drm_memory.h
includecheck fix: include/linux, aio.h
includecheck fix: include/linux, ftrace.h
includecheck fix: include/linux, icmpv6.h
includecheck fix: include/linux, net_dropmon.h
includecheck fix: include/linux, rfkill.h
includecheck fix: kernel/trace, ring_buffer.c
includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c
Documentation/auxdisplay/cfag12864b-example.c | 1 -
arch/arm/boot/compressed/misc.c | 1 -
arch/arm/include/asm/atomic.h | 2 --
arch/arm/mach-davinci/board-dm355-evm.c | 1 -
arch/arm/mach-davinci/board-dm355-leopard.c | 1 -
arch/arm/mach-davinci/board-dm644x-evm.c | 1 -
arch/arm/mach-davinci/board-dm646x-evm.c | 1 -
arch/arm/mach-davinci/board-sffsdr.c | 1 -
arch/arm/mach-mx3/devices.c | 1 -
arch/arm/mach-omap1/mcbsp.c | 1 -
arch/arm/mach-omap2/mcbsp.c | 1 -
arch/arm/plat-s3c64xx/pm.c | 2 --
arch/arm/plat-stmp3xxx/pinmux.c | 1 -
arch/mn10300/kernel/sys_mn10300.c | 1 -
arch/powerpc/kernel/mpc7450-pmu.c | 1 -
arch/powerpc/kernel/ppc970-pmu.c | 1 -
arch/s390/kernel/sys_s390.c | 1 -
arch/um/os-Linux/helper.c | 1 -
arch/x86/kernel/dumpstack.c | 1 -
arch/x86/kernel/traps.c | 1 -
arch/x86/mm/kmemcheck/shadow.c | 1 -
drivers/char/vt.c | 1 -
drivers/net/can/sja1000/sja1000.c | 1 -
drivers/net/pcmcia/axnet_cs.c | 2 --
drivers/net/smc911x.h | 1 -
drivers/parisc/ccio-dma.c | 1 -
drivers/scsi/fcoe/libfcoe.c | 1 -
drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
drivers/spi/amba-pl022.c | 2 --
drivers/staging/otus/usbdrv.c | 3 ---
drivers/staging/rt2860/rt_linux.h | 4 ----
drivers/video/console/vgacon.c | 1 -
drivers/xen/evtchn.c | 1 -
fs/xfs/linux-2.6/xfs_iops.c | 1 -
include/acpi/acpi_bus.h | 1 -
include/drm/drm_memory.h | 2 --
include/linux/aio.h | 2 --
include/linux/ftrace.h | 1 -
include/linux/icmpv6.h | 2 --
include/linux/net_dropmon.h | 1 -
include/linux/rfkill.h | 1 -
kernel/trace/ring_buffer.c | 2 --
mm/nommu.c | 2 --
mm/shmem.c | 1 -
44 files changed, 0 insertions(+), 58 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread* [GIT-PULL] includecheck fixes
2009-07-08 14:28 [PATCH 0/44] includecheck: fix multiple includes Jaswinder Singh Rajput
@ 2009-07-09 18:40 ` Jaswinder Singh Rajput
2009-07-09 22:26 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-09 18:40 UTC (permalink / raw)
To: Linus Torvalds
Cc: Kevin Hilman, David Howells, benh, paulus, schwidefsky,
heiko.carstens, jdike, Ingo Molnar, x86 maintainers, Alan Cox,
David Miller, James Bottomley, dbrownell, Greg KH, mchehab,
jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML, Russell King
Linus,
Please pull includecheck fixes, these all are clean and safe patches
with relevant Acks.
The following changes since commit 34f25476ace556263784ea2f8173e22b25557a13:
Linus Torvalds (1):
Merge branch 'fixes' of git://git.kernel.org/.../davej/cpufreq
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/include-check-2.6.git master
Jaswinder Singh Rajput (42):
includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c
includecheck fix: arm, board-dm355-leopard.c
includecheck fix: arm, board-dm644x-evm.c
includecheck fix: arm, board-dm646x-evm.c
includecheck fix: arm, board-sffsdr.c
includecheck fix: arm, mach-mx3/devices.c
includecheck fix: arm, mach-omap1/mcbsp.c
includecheck fix: arm, mach-omap2/mcbsp.c
includecheck fix: arm, plat-s3c64xx/pm.c
includecheck fix: arm, plat-stmp3xxx/pinmux.c
includecheck fix: mn10300, sys_mn10300.c
includecheck fix: s390, sys_s390.c
includecheck fix: um, helper.c
includecheck fix: x86, dumpstack.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: Documentation, cfag12864b-example.c
includecheck fix: drivers/char, vt.c
includecheck fix: drivers/net, sja1000.c
includecheck fix: drivers/net, axnet_cs.c
includecheck fix: drivers/net, smc911x.h
includecheck fix: drivers/parisc, ccio-dma.c
includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c
includecheck fix: drivers/spi, amba-pl022.c
includecheck fix: drivers/staging, usbdrv.c
includecheck fix: drivers/staging, rt_linux.h
includecheck fix: drivers/video, vgacon.c
includecheck fix: drivers/xen, evtchn.c
includecheck fix: fs/xfs, xfs_iops.c
includecheck fix: include/acpi, acpi_bus.h
includecheck fix: include/drm, drm_memory.h
includecheck fix: include/linux, aio.h
includecheck fix: include/linux, ftrace.h
includecheck fix: include/linux, icmpv6.h
includecheck fix: include/linux, net_dropmon.h
includecheck fix: include/linux, rfkill.h
includecheck fix: kernel/trace, ring_buffer.c
includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c
Documentation/auxdisplay/cfag12864b-example.c | 1 -
arch/arm/boot/compressed/misc.c | 1 -
arch/arm/include/asm/atomic.h | 2 --
arch/arm/mach-davinci/board-dm355-evm.c | 1 -
arch/arm/mach-davinci/board-dm355-leopard.c | 1 -
arch/arm/mach-davinci/board-dm644x-evm.c | 1 -
arch/arm/mach-davinci/board-dm646x-evm.c | 1 -
arch/arm/mach-davinci/board-sffsdr.c | 1 -
arch/arm/mach-mx3/devices.c | 1 -
arch/arm/mach-omap1/mcbsp.c | 1 -
arch/arm/mach-omap2/mcbsp.c | 1 -
arch/arm/plat-s3c64xx/pm.c | 2 --
arch/arm/plat-stmp3xxx/pinmux.c | 1 -
arch/mn10300/kernel/sys_mn10300.c | 1 -
arch/s390/kernel/sys_s390.c | 1 -
arch/um/os-Linux/helper.c | 1 -
arch/x86/kernel/dumpstack.c | 1 -
arch/x86/kernel/traps.c | 1 -
arch/x86/mm/kmemcheck/shadow.c | 1 -
drivers/char/vt.c | 1 -
drivers/net/can/sja1000/sja1000.c | 1 -
drivers/net/pcmcia/axnet_cs.c | 2 --
drivers/net/smc911x.h | 1 -
drivers/parisc/ccio-dma.c | 1 -
drivers/scsi/fcoe/libfcoe.c | 1 -
drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
drivers/spi/amba-pl022.c | 2 --
drivers/staging/otus/usbdrv.c | 3 ---
drivers/staging/rt2860/rt_linux.h | 4 ----
drivers/video/console/vgacon.c | 1 -
drivers/xen/evtchn.c | 1 -
fs/xfs/linux-2.6/xfs_iops.c | 1 -
include/acpi/acpi_bus.h | 1 -
include/drm/drm_memory.h | 2 --
include/linux/aio.h | 2 --
include/linux/ftrace.h | 1 -
include/linux/icmpv6.h | 2 --
include/linux/net_dropmon.h | 1 -
include/linux/rfkill.h | 1 -
kernel/trace/ring_buffer.c | 2 --
mm/nommu.c | 2 --
mm/shmem.c | 1 -
42 files changed, 0 insertions(+), 56 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [GIT-PULL] includecheck fixes
2009-07-09 18:40 ` [GIT-PULL] includecheck fixes Jaswinder Singh Rajput
@ 2009-07-09 22:26 ` Greg KH
2009-07-10 2:59 ` Jaswinder Singh Rajput
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2009-07-09 22:26 UTC (permalink / raw)
To: Jaswinder Singh Rajput
Cc: Linus Torvalds, Kevin Hilman, David Howells, benh, paulus,
schwidefsky, heiko.carstens, jdike, Ingo Molnar, x86 maintainers,
Alan Cox, David Miller, James Bottomley, dbrownell, mchehab,
jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML, Russell King
On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> Linus,
>
> Please pull includecheck fixes, these all are clean and safe patches
> with relevant Acks.
Shouldn't stuff like this go through the trivial tree? And stuff like
that is relevant for the main pre-rc1 merge, not this late in the merge
cycle, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [GIT-PULL] includecheck fixes
2009-07-09 22:26 ` Greg KH
@ 2009-07-10 2:59 ` Jaswinder Singh Rajput
2009-07-10 3:22 ` James Bottomley
2009-07-10 3:35 ` Greg KH
0 siblings, 2 replies; 9+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-10 2:59 UTC (permalink / raw)
To: Greg KH
Cc: Linus Torvalds, Kevin Hilman, David Howells, benh, paulus,
schwidefsky, heiko.carstens, jdike, Ingo Molnar, x86 maintainers,
Alan Cox, David Miller, James Bottomley, dbrownell, mchehab,
jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML, Russell King
Hello Greg,
On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > Linus,
> >
> > Please pull includecheck fixes, these all are clean and safe patches
> > with relevant Acks.
>
> Shouldn't stuff like this go through the trivial tree? And stuff like
> that is relevant for the main pre-rc1 merge, not this late in the merge
> cycle, right?
>
You did not specified what is your problem ? and where was you when we
discussed it earlier ?
Normally brain is above then the eyes, do you know why ?
To use your brain instead of follow things blindly.
The point of watching patches for some time means test and wait so that
they can show their real faces.
BTW, it is not late, it is not going to hit stable in next week or so.
Keeping these sane patches waiting for complete cycle will be insaner.
Thanks,
--
JSR
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [GIT-PULL] includecheck fixes
2009-07-10 2:59 ` Jaswinder Singh Rajput
@ 2009-07-10 3:22 ` James Bottomley
2009-07-10 3:41 ` Jaswinder Singh Rajput
2009-07-10 3:35 ` Greg KH
1 sibling, 1 reply; 9+ messages in thread
From: James Bottomley @ 2009-07-10 3:22 UTC (permalink / raw)
To: Jaswinder Singh Rajput
Cc: Greg KH, Linus Torvalds, Kevin Hilman, David Howells, benh,
paulus, schwidefsky, heiko.carstens, jdike, Ingo Molnar,
x86 maintainers, Alan Cox, David Miller, dbrownell, mchehab,
jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML, Russell King, Jiri Kosina
On Fri, 2009-07-10 at 08:29 +0530, Jaswinder Singh Rajput wrote:
> Hello Greg,
>
> On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull includecheck fixes, these all are clean and safe patches
> > > with relevant Acks.
> >
> > Shouldn't stuff like this go through the trivial tree? And stuff like
> > that is relevant for the main pre-rc1 merge, not this late in the merge
> > cycle, right?
> >
>
> You did not specified what is your problem ? and where was you when we
> discussed it earlier ?
The problem, as you have been told several times, is that maintainers
are very busy people and don't necessarily have time to deal with
mechanical replacement trivia like this.
The point is that Jiri Kosina takes that burden on himself to verify and
submit the changes like this, so something like this should go through
him.
> Normally brain is above then the eyes, do you know why ?
>
> To use your brain instead of follow things blindly.
>
> The point of watching patches for some time means test and wait so that
> they can show their real faces.
Abusing people who do real work, particularly when you manifestly do
not, is a gross breach of etiquette ... welcome to my killfile.
James
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [GIT-PULL] includecheck fixes
2009-07-10 3:22 ` James Bottomley
@ 2009-07-10 3:41 ` Jaswinder Singh Rajput
2009-07-10 8:49 ` Jiri Kosina
0 siblings, 1 reply; 9+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-10 3:41 UTC (permalink / raw)
To: James Bottomley; +Cc: Greg KH, LKML, Jiri Kosina
Hello James,
On Fri, 2009-07-10 at 03:22 +0000, James Bottomley wrote:
> On Fri, 2009-07-10 at 08:29 +0530, Jaswinder Singh Rajput wrote:
> > Hello Greg,
> >
> > On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > > Linus,
> > > >
> > > > Please pull includecheck fixes, these all are clean and safe patches
> > > > with relevant Acks.
> > >
> > > Shouldn't stuff like this go through the trivial tree? And stuff like
> > > that is relevant for the main pre-rc1 merge, not this late in the merge
> > > cycle, right?
> > >
> >
> > You did not specified what is your problem ? and where was you when we
> > discussed it earlier ?
>
> The problem, as you have been told several times, is that maintainers
> are very busy people and don't necessarily have time to deal with
> mechanical replacement trivia like this.
>
Am I asking you ?
If you are very busy and not able to handle things properly, so better
quit the maintainer-ship. Others can handle more better than you.
> The point is that Jiri Kosina takes that burden on himself to verify and
> submit the changes like this, so something like this should go through
> him.
>
Who will take burden of Jiri, I already send another PULL request to
Jiri.
> > Normally brain is above then the eyes, do you know why ?
> >
> > To use your brain instead of follow things blindly.
> >
> > The point of watching patches for some time means test and wait so that
> > they can show their real faces.
>
> Abusing people who do real work, particularly when you manifestly do
> not, is a gross breach of etiquette ... welcome to my killfile.
>
So what you mean, you can do any crap and no one can blame you ...
welcome to my killknife.
--
JSR
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [GIT-PULL] includecheck fixes
2009-07-10 3:41 ` Jaswinder Singh Rajput
@ 2009-07-10 8:49 ` Jiri Kosina
0 siblings, 0 replies; 9+ messages in thread
From: Jiri Kosina @ 2009-07-10 8:49 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: James Bottomley, Greg KH, LKML
On Fri, 10 Jul 2009, Jaswinder Singh Rajput wrote:
> > > > > Please pull includecheck fixes, these all are clean and safe
> > > > > patches with relevant Acks.
> > > > Shouldn't stuff like this go through the trivial tree? And stuff
> > > > like that is relevant for the main pre-rc1 merge, not this late in
> > > > the merge cycle, right?
> > > You did not specified what is your problem ? and where was you when
> > > we discussed it earlier ?
> > The problem, as you have been told several times, is that maintainers
> > are very busy people and don't necessarily have time to deal with
> > mechanical replacement trivia like this.
> Am I asking you ? If you are very busy and not able to handle things
> properly, so better quit the maintainer-ship. Others can handle more
> better than you.
Come on Jaswinder ... trivial grammar/typo fixes are really not that
important stuff to argue about in longish threads. Let's rather find a
more interesting and important topic to flame each other about :) This is
really not worth it.
> > The point is that Jiri Kosina takes that burden on himself to verify
> > and submit the changes like this, so something like this should go
> > through him.
> Who will take burden of Jiri, I already send another PULL request to
> Jiri.
If you mean the "foo foo" replacement request, the repository you asked me
to pull from doesn't seem to have any extra patches on top of current
tree, so I guess you forgot to push.
Also you can't expect that I react to trivial patches very promptly. There
are a lot of more urgent things that I am taking care of, this is just an
"add-on".
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [GIT-PULL] includecheck fixes
2009-07-10 2:59 ` Jaswinder Singh Rajput
2009-07-10 3:22 ` James Bottomley
@ 2009-07-10 3:35 ` Greg KH
2009-07-10 3:50 ` Jaswinder Singh Rajput
1 sibling, 1 reply; 9+ messages in thread
From: Greg KH @ 2009-07-10 3:35 UTC (permalink / raw)
To: Jaswinder Singh Rajput
Cc: Linus Torvalds, Kevin Hilman, David Howells, benh, paulus,
schwidefsky, heiko.carstens, jdike, Ingo Molnar, x86 maintainers,
Alan Cox, David Miller, James Bottomley, dbrownell, mchehab,
jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML, Russell King
On Fri, Jul 10, 2009 at 08:29:15AM +0530, Jaswinder Singh Rajput wrote:
> Hello Greg,
>
> On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull includecheck fixes, these all are clean and safe patches
> > > with relevant Acks.
> >
> > Shouldn't stuff like this go through the trivial tree? And stuff like
> > that is relevant for the main pre-rc1 merge, not this late in the merge
> > cycle, right?
> >
>
> You did not specified what is your problem ? and where was you when we
> discussed it earlier ?
Earlier when? I responded to your query about the individual patches
you copied me on, saying they were in my "to-apply" queue and I didn't
want them to go to Linus at this point in time. You seem quite rushed
about these patches, which is odd to me.
> Normally brain is above then the eyes, do you know why ?
>
> To use your brain instead of follow things blindly.
>
> The point of watching patches for some time means test and wait so that
> they can show their real faces.
Which is what I am asking you to do here. So why are you arguing with
this concept?
> BTW, it is not late, it is not going to hit stable in next week or so.
>
> Keeping these sane patches waiting for complete cycle will be insaner.
Accepting trivial patches like these, for which a full build cycle of
all arches has yet to be accomplished due to a lack of inclusion in the
-next tree, at a point in the development series in which bug fixes and
regressions are the only thing to be accepted, seems to be a risk, don't
you think?
But hey, I'm not Linus, it's up to him to decide to take untested stuff
like this or not, not me :)
best of luck,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [GIT-PULL] includecheck fixes
2009-07-10 3:35 ` Greg KH
@ 2009-07-10 3:50 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 9+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-10 3:50 UTC (permalink / raw)
To: Greg KH
Cc: Linus Torvalds, Kevin Hilman, David Howells, benh, paulus,
schwidefsky, heiko.carstens, jdike, Ingo Molnar, x86 maintainers,
Alan Cox, David Miller, James Bottomley, dbrownell, mchehab,
jeremy, felixb, lenb, airlied, bcrl, Steven Rostedt,
Andrew Morton, Sam Ravnborg, LKML, Russell King
On Thu, 2009-07-09 at 20:35 -0700, Greg KH wrote:
> On Fri, Jul 10, 2009 at 08:29:15AM +0530, Jaswinder Singh Rajput wrote:
> > Hello Greg,
> >
> > On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > > Linus,
> > > >
> > > > Please pull includecheck fixes, these all are clean and safe patches
> > > > with relevant Acks.
> > >
> > > Shouldn't stuff like this go through the trivial tree? And stuff like
> > > that is relevant for the main pre-rc1 merge, not this late in the merge
> > > cycle, right?
> > >
> >
> > You did not specified what is your problem ? and where was you when we
> > discussed it earlier ?
>
> Earlier when?
Check LKML emails of this thread, I have send half-dozen of emails to
you earlier.
Thanks,
--
JSR
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-09-20 11:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-20 11:52 [GIT-PULL] includecheck fixes Jaswinder Singh Rajput
-- strict thread matches above, loose matches on Subject: below --
2009-07-08 14:28 [PATCH 0/44] includecheck: fix multiple includes Jaswinder Singh Rajput
2009-07-09 18:40 ` [GIT-PULL] includecheck fixes Jaswinder Singh Rajput
2009-07-09 22:26 ` Greg KH
2009-07-10 2:59 ` Jaswinder Singh Rajput
2009-07-10 3:22 ` James Bottomley
2009-07-10 3:41 ` Jaswinder Singh Rajput
2009-07-10 8:49 ` Jiri Kosina
2009-07-10 3:35 ` Greg KH
2009-07-10 3:50 ` Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox