From: Stanislav Brabec <utx@penguin.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
Dirk@Opfer-Online.de, arminlitzel@web.de,
Cyril Hrubis <metan@ucw.cz>,
thommycheck@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dbaryshkov@gmail.com, omegamoon@gmail.com, eric.y.miao@gmail.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: spitz: add gpio button support (AK_INT and remote control description)
Date: Wed, 07 Oct 2009 13:29:51 +0200 [thread overview]
Message-ID: <1254914991.4213.80.camel@hammer.suse.cz> (raw)
In-Reply-To: <20091007085806.GB28807@elf.ucw.cz>
Pavel Machek wrote:
> On Tue 2009-10-06 13:48:52, Stanislav Brabec wrote:
> > Pavel Machek wrote:
> > > I'm not sure what AK_INT is, nor what event it should
> > > generate.
> >
> > AK_INT: remote control detect
>
> Thanks. So for now I'll do:
>
> /* This is for remote control support. Zaurus supports wired
> remote on headphones. */
> {
> .type = EV_KEY,
> .code = KEY_F13,
> .gpio = SPITZ_GPIO_AK_INT,
> .desc = "Wired remote (AK_INT)",
> },
>
> ..and leave it for proper driver to support nicely.
I think that AK_INT should not generate key press event. Permanently
pressed key could confuse many programs.
But we may want to use switch events. I propose to create new switch
event for it: SW_REMOTE_INSERT. But mapping of AK_INT to
SW_REMOTE_INSERT cannot be straightforward.
That is why I propose to ignore AK_INT for now.
Following implementation may be used later (with future resistor matrix
keyboard driver):
Map SPITZ_GPIO_HP_IN to SW_JACK_PHYSICAL_INSERT (after debouncing).
Generate SW_REMOTE_INSERT if:
- SW_JACK_PHYSICAL_INSERT is on AK_INT is active and remote pin has full
voltage
or
- SW_JACK_PHYSICAL_INSERT is on and remote driver shows valid value
SW_REMOTE_INSERT should be recognized by the Jack abstraction layer
(sound/core/jack.c).
Well, I am thinking about defining extra values for resistors, that can
make stuff even more useful at cost of need of non-standard wiring on
fourth ring of the audio jack. It can generate SW_MICROPHONE_INSERT,
SW_LINEOUT_INSERT, and not yet defined SW_HEADESET_INSERT and
SW_LINEIN_INSERT (which would require hardware mod inside Zaurus for
stereo line-in).
The default may be SW_HEADPHONE_INSERT (short connection between remote
pin and ground).
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/
next prev parent reply other threads:[~2009-10-07 11:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 7:46 spitz: add gpio button support Pavel Machek
2009-10-06 11:48 ` spitz: add gpio button support (AK_INT and remote control description) Stanislav Brabec
2009-10-07 8:58 ` Pavel Machek
2009-10-07 11:29 ` Stanislav Brabec [this message]
2009-10-07 12:06 ` Mark Brown
2009-10-07 14:27 ` Eric Miao
2009-10-06 20:09 ` spitz: add gpio button support (fixes regression) Pavel Machek
2009-10-15 21:16 ` Stanislav Brabec
2009-10-15 21:20 ` Pavel Machek
2009-10-15 21:47 ` Stanislav Brabec
2009-10-15 21:52 ` Pavel Machek
2009-10-16 3:01 ` Eric Miao
2009-10-16 9:28 ` Stanislav Brabec
2009-10-16 9:39 ` Pavel Machek
2009-10-16 18:50 ` [PATCH] " Stanislav Brabec
2009-10-16 19:05 ` Russell King - ARM Linux
2009-10-16 22:22 ` Stanislav Brabec
2009-10-17 4:42 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254914991.4213.80.camel@hammer.suse.cz \
--to=utx@penguin.cz \
--cc=Dirk@Opfer-Online.de \
--cc=arminlitzel@web.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metan@ucw.cz \
--cc=omegamoon@gmail.com \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=thommycheck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox