From: Pavel Machek <pavel@ucw.cz>
To: Stanislav Brabec <utx@penguin.cz>
Cc: Eric Miao <eric.y.miao@gmail.com>, Andrew Morton <akpm@osdl.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
Dirk@opfer-online.de, arminlitzel@web.de,
Cyril Hrubis <metan@ucw.cz>,
thommycheck@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dbaryshkov@gmail.com, omegamoon@gmail.com
Subject: Re: spitz: add gpio button support (fixes regression)
Date: Thu, 15 Oct 2009 23:52:15 +0200 [thread overview]
Message-ID: <20091015215215.GG15898@elf.ucw.cz> (raw)
In-Reply-To: <1255643252.3985.63.camel@utx.utx.cz>
On Thu 2009-10-15 23:47:32, Stanislav Brabec wrote:
> Pavel Machek wrote:
> >Well, resume is hit by second regression.
> >
> >Suspend key.... I restored it to the level of functionality in
> >2.6.31 :-).
>
> > > + .type = EV_KEY,
> > > + .code = KEY_SUSPEND,
>
> I guess it should be EV_PWR. Then it will at least go to suspend.
Does it actually go to suspend with that change?
(Actually, I wonder how it could have ever worked: userspace should
certainly be in a loop there; kernel should not suspend machine on its
own. In -rp kernels, kernel _does_ suspend on its own, but... I'm not
sure if that's suitable for mainline).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-15 21:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 7:46 spitz: add gpio button support Pavel Machek
2009-10-06 11:48 ` spitz: add gpio button support (AK_INT and remote control description) Stanislav Brabec
2009-10-07 8:58 ` Pavel Machek
2009-10-07 11:29 ` Stanislav Brabec
2009-10-07 12:06 ` Mark Brown
2009-10-07 14:27 ` Eric Miao
2009-10-06 20:09 ` spitz: add gpio button support (fixes regression) Pavel Machek
2009-10-15 21:16 ` Stanislav Brabec
2009-10-15 21:20 ` Pavel Machek
2009-10-15 21:47 ` Stanislav Brabec
2009-10-15 21:52 ` Pavel Machek [this message]
2009-10-16 3:01 ` Eric Miao
2009-10-16 9:28 ` Stanislav Brabec
2009-10-16 9:39 ` Pavel Machek
2009-10-16 18:50 ` [PATCH] " Stanislav Brabec
2009-10-16 19:05 ` Russell King - ARM Linux
2009-10-16 22:22 ` Stanislav Brabec
2009-10-17 4:42 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015215215.GG15898@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=Dirk@opfer-online.de \
--cc=akpm@osdl.org \
--cc=arminlitzel@web.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metan@ucw.cz \
--cc=omegamoon@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=thommycheck@gmail.com \
--cc=utx@penguin.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox