From: Peter Zijlstra <peterz@infradead.org>
To: svaidy@linux.vnet.ibm.com
Cc: Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Ingo Molnar <mingo@elte.hu>, Gautham R Shenoy <ego@in.ibm.com>,
Arun Bharadwaj <arun@linux.vnet.ibm.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG: sched_mc_powersavings broken on pre-Nehalem x86 platforms
Date: Mon, 08 Feb 2010 12:35:48 +0100 [thread overview]
Message-ID: <1265628948.1853.43.camel@laptop> (raw)
In-Reply-To: <20100208100555.GD2931@dirshya.in.ibm.com>
On Mon, 2010-02-08 at 15:35 +0530, Vaidyanathan Srinivasan wrote:
> Fix for sched_mc_powersavigs for pre-Nehalem platforms.
> Child sched domain should clear SD_PREFER_SIBLING if parent will have
> SD_POWERSAVINGS_BALANCE because they are contradicting.
>
> Sets the flags correctly based on sched_mc_power_savings.
>
> Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 6550415..ef6b7cd 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -866,7 +866,10 @@ static inline int sd_balance_for_mc_power(void)
> if (sched_smt_power_savings)
> return SD_POWERSAVINGS_BALANCE;
>
> - return SD_PREFER_SIBLING;
> + if (!sched_mc_power_savings)
> + return SD_PREFER_SIBLING;
> +
> + return 0;
> }
>
> static inline int sd_balance_for_package_power(void)
>
Looks good, thanks!
What's the status of getting rid of sched_{mc,smt}_power_savings?
next prev parent reply other threads:[~2010-02-08 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 10:05 BUG: sched_mc_powersavings broken on pre-Nehalem x86 platforms Vaidyanathan Srinivasan
2010-02-08 11:35 ` Peter Zijlstra [this message]
2010-02-08 12:46 ` Vaidyanathan Srinivasan
2010-02-16 14:15 ` [tip:sched/urgent] sched: Fix sched_mv_power_savings for !SMT tip-bot for Vaidyanathan Srinivasan
2010-02-16 16:01 ` Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265628948.1853.43.camel@laptop \
--to=peterz@infradead.org \
--cc=arun@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox