From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
a.p.zijlstra@chello.nl, tglx@linutronix.de
Subject: Re: [tip:sched/urgent] sched: Fix sched_mv_power_savings for !SMT
Date: Tue, 16 Feb 2010 21:31:31 +0530 [thread overview]
Message-ID: <20100216160131.GD8777@dirshya.in.ibm.com> (raw)
In-Reply-To: <tip-28f5318167adf23b16c844b9c2253f355cb21796@git.kernel.org>
* tip-bot for Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> [2010-02-16 14:15:43]:
> Commit-ID: 28f5318167adf23b16c844b9c2253f355cb21796
> Gitweb: http://git.kernel.org/tip/28f5318167adf23b16c844b9c2253f355cb21796
> Author: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
> AuthorDate: Mon, 8 Feb 2010 15:35:55 +0530
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Tue, 16 Feb 2010 15:13:59 +0100
>
> sched: Fix sched_mv_power_savings for !SMT
^^^^^ _mc_
Minor typo, the summary should be
"sched: Fix sched_mc_power_savings for !SMT cases"
Thanks,
Vaidy
> Fix for sched_mc_powersavigs for pre-Nehalem platforms.
> Child sched domain should clear SD_PREFER_SIBLING if parent will have
> SD_POWERSAVINGS_BALANCE because they are contradicting.
>
> Sets the flags correctly based on sched_mc_power_savings.
>
> Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> LKML-Reference: <20100208100555.GD2931@dirshya.in.ibm.com>
> Cc: stable@kernel.org [2.6.32.x]
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> include/linux/sched.h | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 78efe7c..1f5fa53 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -878,7 +878,10 @@ static inline int sd_balance_for_mc_power(void)
> if (sched_smt_power_savings)
> return SD_POWERSAVINGS_BALANCE;
>
> - return SD_PREFER_SIBLING;
> + if (!sched_mc_power_savings)
> + return SD_PREFER_SIBLING;
> +
> + return 0;
> }
>
> static inline int sd_balance_for_package_power(void)
prev parent reply other threads:[~2010-02-16 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 10:05 BUG: sched_mc_powersavings broken on pre-Nehalem x86 platforms Vaidyanathan Srinivasan
2010-02-08 11:35 ` Peter Zijlstra
2010-02-08 12:46 ` Vaidyanathan Srinivasan
2010-02-16 14:15 ` [tip:sched/urgent] sched: Fix sched_mv_power_savings for !SMT tip-bot for Vaidyanathan Srinivasan
2010-02-16 16:01 ` Vaidyanathan Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216160131.GD8777@dirshya.in.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox