* [PATCH] Staging: dream: camera: sk5k3e2fx: fix code style issues
@ 2010-02-25 23:20 Chihau Chau
2010-02-26 7:04 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Chihau Chau @ 2010-02-25 23:20 UTC (permalink / raw)
To: gregkh; +Cc: pavel, linux-kernel, devel, Chihau Chau
From: Chihau Chau <chihau@gmail.com>
This fixes some code style issues about assignments in if conditions.
Signed-off-by: Chihau Chau <chihau@gmail.com>
---
drivers/staging/dream/camera/s5k3e2fx.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dream/camera/s5k3e2fx.c b/drivers/staging/dream/camera/s5k3e2fx.c
index edba198..2426f5e 100644
--- a/drivers/staging/dream/camera/s5k3e2fx.c
+++ b/drivers/staging/dream/camera/s5k3e2fx.c
@@ -743,12 +743,12 @@ static int s5k3e2fx_sensor_open_init(const struct msm_camera_sensor_info *data)
}
/* initialize AF */
- if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr,
- 0x3146, 0x3A)) < 0)
+ rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3146, 0x3A);
+ if (rc < 0)
goto init_fail1;
- if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr,
- 0x3130, 0x03)) < 0)
+ rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3130, 0x03);
+ if (rc < 0)
goto init_fail1;
goto init_done;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: dream: camera: sk5k3e2fx: fix code style issues
2010-02-25 23:20 [PATCH] Staging: dream: camera: sk5k3e2fx: fix code style issues Chihau Chau
@ 2010-02-26 7:04 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2010-02-26 7:04 UTC (permalink / raw)
To: Chihau Chau; +Cc: gregkh, linux-kernel, devel
> From: Chihau Chau <chihau@gmail.com>
>
> This fixes some code style issues about assignments in if conditions.
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>
ACK.
> ---
> drivers/staging/dream/camera/s5k3e2fx.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/dream/camera/s5k3e2fx.c b/drivers/staging/dream/camera/s5k3e2fx.c
> index edba198..2426f5e 100644
> --- a/drivers/staging/dream/camera/s5k3e2fx.c
> +++ b/drivers/staging/dream/camera/s5k3e2fx.c
> @@ -743,12 +743,12 @@ static int s5k3e2fx_sensor_open_init(const struct msm_camera_sensor_info *data)
> }
>
> /* initialize AF */
> - if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr,
> - 0x3146, 0x3A)) < 0)
> + rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3146, 0x3A);
> + if (rc < 0)
> goto init_fail1;
>
> - if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr,
> - 0x3130, 0x03)) < 0)
> + rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3130, 0x03);
> + if (rc < 0)
> goto init_fail1;
>
> goto init_done;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-26 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 23:20 [PATCH] Staging: dream: camera: sk5k3e2fx: fix code style issues Chihau Chau
2010-02-26 7:04 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox