* [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m
@ 2010-03-02 20:59 Surbhi Palande
2010-03-03 23:34 ` Eric Anholt
0 siblings, 1 reply; 3+ messages in thread
From: Surbhi Palande @ 2010-03-02 20:59 UTC (permalink / raw)
To: dri-devel
Cc: linux-kernel, airlied, eric, yakui.zhao, jbarnes, airlied,
zhenyuw
BugLink: https://bugs.launchpad.net/bugs/515246
Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
when it is open. This leads to a "no connectors reported" error at startup.
Blacklisting them, to always return a connected status for the default
lvds connector.
Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
---
Due to lack of hardware, I have not tested this patch on my own. Further
testing shall be helpful.
drivers/gpu/drm/i915/intel_lvds.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index c2e8a45..b94a5e5 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -643,6 +643,20 @@ static const struct dmi_system_id bad_lid_status[] = {
DMI_MATCH(DMI_BOARD_NAME, "M5x0N"),
},
},
+ {
+ .ident = "Sony VGN-BX196VP",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+ DMI_MATCH(DMI_BOARD_NAME, "VGN-BX196VP"),
+ },
+ },
+ {
+ .ident = "Dell Inspiron 700m",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
+ DMI_MATCH(DMI_BOARD_NAME, "Inspiron 700m"),
+ },
+ },
{ }
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m
2010-03-02 20:59 [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m Surbhi Palande
@ 2010-03-03 23:34 ` Eric Anholt
2010-03-05 7:50 ` Surbhi Palande
0 siblings, 1 reply; 3+ messages in thread
From: Eric Anholt @ 2010-03-03 23:34 UTC (permalink / raw)
To: Surbhi Palande, dri-devel
Cc: linux-kernel, airlied, yakui.zhao, jbarnes, airlied, zhenyuw
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Tue, 2 Mar 2010 22:59:52 +0200, Surbhi Palande <surbhi.palande@canonical.com> wrote:
> BugLink: https://bugs.launchpad.net/bugs/515246
>
> Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
> when it is open. This leads to a "no connectors reported" error at startup.
> Blacklisting them, to always return a connected status for the default
> lvds connector.
>
> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
As far as I know, this should already be covered by:
commit 7b9c5abee98c54f85bcc04bd4d7ec8d5094c73f4
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date: Fri Feb 12 09:30:00 2010 -0800
drm/i915: give up on 8xx lid status
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m
2010-03-03 23:34 ` Eric Anholt
@ 2010-03-05 7:50 ` Surbhi Palande
0 siblings, 0 replies; 3+ messages in thread
From: Surbhi Palande @ 2010-03-05 7:50 UTC (permalink / raw)
To: Eric Anholt
Cc: dri-devel, linux-kernel, airlied, yakui.zhao, jbarnes, airlied,
zhenyuw
Hi Eric,
On Wed, 2010-03-03 at 15:34 -0800, Eric Anholt wrote:
> On Tue, 2 Mar 2010 22:59:52 +0200, Surbhi Palande <surbhi.palande@canonical.com> wrote:
> > BugLink: https://bugs.launchpad.net/bugs/515246
> >
> > Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
> > when it is open. This leads to a "no connectors reported" error at startup.
> > Blacklisting them, to always return a connected status for the default
> > lvds connector.
> >
> > Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
>
> As far as I know, this should already be covered by:
>
> commit 7b9c5abee98c54f85bcc04bd4d7ec8d5094c73f4
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date: Fri Feb 12 09:30:00 2010 -0800
>
> drm/i915: give up on 8xx lid status
Yes I agree. Thanks for the comment.
However, the "drm/i915: give up on 8xx lid status" will work for the
Dell Inspiron 700m. But, the Sony VGN-BX196VP will still need to be
blacklisted as it is a 915GM device.
If you agree with this, I will rewrite the patch and send you another
version.
Thanks!
Warm Regards,
Surbhi.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-05 7:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 20:59 [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m Surbhi Palande
2010-03-03 23:34 ` Eric Anholt
2010-03-05 7:50 ` Surbhi Palande
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox