[PATCH] Staging: adis16255: Fix compile error

[PATCH] Staging: adis16255: Fix compile error

[Javier Martinez Canillas]

This patch solves a compilation error in today linux-next tree.

The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
 drivers/staging/adis16255/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/adis16255/Makefile b/drivers/staging/adis16255/Makefile
index 3f8b1f0..dc4debc 100644
--- a/drivers/staging/adis16255/Makefile
+++ b/drivers/staging/adis16255/Makefile
@@ -1 +1 @@
-obj-$(CONFIG_ADIS16255) +�is16255.o
+obj-$(CONFIG_ADIS16255)                += adis1625.o
-- 
1.7.0.4

Re: [PATCH] Staging: adis16255: Fix compile error

[Barry Song]

The main work of this driver is providing sys node for users to access
data. Which directory will this driver be placed after moving from
staging? It's better to rewrite it based on IIO. Otherwise, the
architecture for this kind of driver will be difficult to be
consistent.
-barry

On Mon, May 3, 2010 at 1:05 AM, Javier Martinez Canillas
<martinez.javier@gmail.com> wrote:
>
> This patch solves a compilation error in today linux-next tree.
>
> The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
>  drivers/staging/adis16255/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/adis16255/Makefile b/drivers/staging/adis16255/Makefile
> index 3f8b1f0..dc4debc 100644
> --- a/drivers/staging/adis16255/Makefile
> +++ b/drivers/staging/adis16255/Makefile
> @@ -1 +1 @@
> -obj-$(CONFIG_ADIS16255) +�is16255.o
> +obj-$(CONFIG_ADIS16255)                += adis1625.o
> --
> 1.7.0.4
>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Staging: adis16255: Fix compile error

[matthias]

Hi.

2010/5/4 Barry Song <21cnbao@gmail.com>:
> The main work of this driver is providing sys node for users to access
> data. Which directory will this driver be placed after moving from
> staging? It's better to rewrite it based on IIO. Otherwise, the
> architecture for this kind of driver will be difficult to be
> consistent.

It's not yet decided to which subsystem the driver will be merged to.
But sysfs entries go to /sys/bus/spi/drivers/ so there shouldn't be an
issue if it later moves to IIO.
(what I want to do when IIO gets out of staging).

Regards,
Matthias Brugger

> -barry
>

-- 
motzblog.wordpress.com