* [PATCH] led-class: set permissions on max_brightness file to 0444
@ 2010-05-17 0:48 Axel Lin
2010-05-26 11:28 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-05-17 0:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Richard Purdie, John Lenz
max_brightness is not writable, thus set permissions to 0444.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/leds/led-class.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 69e7d86..2606600 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -74,7 +74,7 @@ static ssize_t led_max_brightness_show(struct device *dev,
static struct device_attribute led_class_attrs[] = {
__ATTR(brightness, 0644, led_brightness_show, led_brightness_store),
- __ATTR(max_brightness, 0644, led_max_brightness_show, NULL),
+ __ATTR(max_brightness, 0444, led_max_brightness_show, NULL),
#ifdef CONFIG_LEDS_TRIGGERS
__ATTR(trigger, 0644, led_trigger_show, led_trigger_store),
#endif
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] led-class: set permissions on max_brightness file to 0444
2010-05-17 0:48 [PATCH] led-class: set permissions on max_brightness file to 0444 Axel Lin
@ 2010-05-26 11:28 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2010-05-26 11:28 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, John Lenz
On Mon, 2010-05-17 at 08:48 +0800, Axel Lin wrote:
> max_brightness is not writable, thus set permissions to 0444.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/leds/led-class.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 69e7d86..2606600 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -74,7 +74,7 @@ static ssize_t led_max_brightness_show(struct device *dev,
>
> static struct device_attribute led_class_attrs[] = {
> __ATTR(brightness, 0644, led_brightness_show, led_brightness_store),
> - __ATTR(max_brightness, 0644, led_max_brightness_show, NULL),
> + __ATTR(max_brightness, 0444, led_max_brightness_show, NULL),
> #ifdef CONFIG_LEDS_TRIGGERS
> __ATTR(trigger, 0644, led_trigger_show, led_trigger_store),
> #endif
Queued in the leds tree, thanks.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-26 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-17 0:48 [PATCH] led-class: set permissions on max_brightness file to 0444 Axel Lin
2010-05-26 11:28 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox