The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tom Zanussi <tzanussi@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
	fweisbec@gmail.com, acme@infradead.org,
	perfmon2-devel@lists.sf.net, eranian@gmail.com
Subject: Re: [BUG] perf: installed python -report scripts have bogus paths
Date: Thu, 17 Jun 2010 23:22:57 -0500	[thread overview]
Message-ID: <1276834977.7762.4.camel@tropicana> (raw)
In-Reply-To: <AANLkTinB-0TzyRnjvOwWFetub1-4lhqxXFxYwsOhL3Kl@mail.gmail.com>

Hi,

On Thu, 2010-06-17 at 16:54 +0200, Stephane Eranian wrote:
> Hi,
> 
> I was looking at the perf trace and python scripting support.
> But I quickly ran into an issue. I compiled with:
> $ make prefix=/usr
> $ make prefix=/usr install
> 
> All the scripts are installed in /usr/libexec/perf-core/scripts/.....
> 
> The problem is that all the -report scripts have the .py script
> paths hardcoded as ~/libexec/.....
> 
> Here is an example with syscall-counts-report
> perf trace $@ -s ~/libexec/perf-core/scripts/python/syscall-counts.py $comm
> 
> That should either be stripped to syscall-counts.py and perf trace adds the
> prefix or make install needs to patch the path in. Otherwise I don't see how
> this can work unless I am confused about the usage model.

You're right - it's not a great idea to be hard-coding the path in like
this.

I'll submit a patch shortly to have perf trace add the prefix.

Thanks,

Tom



      reply	other threads:[~2010-06-18  4:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 14:54 [BUG] perf: installed python -report scripts have bogus paths Stephane Eranian
2010-06-18  4:22 ` Tom Zanussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276834977.7762.4.camel@tropicana \
    --to=tzanussi@gmail.com \
    --cc=acme@infradead.org \
    --cc=davem@davemloft.net \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox