* [BUG] perf: installed python -report scripts have bogus paths
@ 2010-06-17 14:54 Stephane Eranian
2010-06-18 4:22 ` Tom Zanussi
0 siblings, 1 reply; 2+ messages in thread
From: Stephane Eranian @ 2010-06-17 14:54 UTC (permalink / raw)
To: linux-kernel
Cc: peterz, mingo, paulus, davem, fweisbec, acme, perfmon2-devel,
eranian, eranian, Tom Zanussi
Hi,
I was looking at the perf trace and python scripting support.
But I quickly ran into an issue. I compiled with:
$ make prefix=/usr
$ make prefix=/usr install
All the scripts are installed in /usr/libexec/perf-core/scripts/.....
The problem is that all the -report scripts have the .py script
paths hardcoded as ~/libexec/.....
Here is an example with syscall-counts-report
perf trace $@ -s ~/libexec/perf-core/scripts/python/syscall-counts.py $comm
That should either be stripped to syscall-counts.py and perf trace adds the
prefix or make install needs to patch the path in. Otherwise I don't see how
this can work unless I am confused about the usage model.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] perf: installed python -report scripts have bogus paths
2010-06-17 14:54 [BUG] perf: installed python -report scripts have bogus paths Stephane Eranian
@ 2010-06-18 4:22 ` Tom Zanussi
0 siblings, 0 replies; 2+ messages in thread
From: Tom Zanussi @ 2010-06-18 4:22 UTC (permalink / raw)
To: Stephane Eranian
Cc: linux-kernel, peterz, mingo, paulus, davem, fweisbec, acme,
perfmon2-devel, eranian
Hi,
On Thu, 2010-06-17 at 16:54 +0200, Stephane Eranian wrote:
> Hi,
>
> I was looking at the perf trace and python scripting support.
> But I quickly ran into an issue. I compiled with:
> $ make prefix=/usr
> $ make prefix=/usr install
>
> All the scripts are installed in /usr/libexec/perf-core/scripts/.....
>
> The problem is that all the -report scripts have the .py script
> paths hardcoded as ~/libexec/.....
>
> Here is an example with syscall-counts-report
> perf trace $@ -s ~/libexec/perf-core/scripts/python/syscall-counts.py $comm
>
> That should either be stripped to syscall-counts.py and perf trace adds the
> prefix or make install needs to patch the path in. Otherwise I don't see how
> this can work unless I am confused about the usage model.
You're right - it's not a great idea to be hard-coding the path in like
this.
I'll submit a patch shortly to have perf trace add the prefix.
Thanks,
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-18 4:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-17 14:54 [BUG] perf: installed python -report scripts have bogus paths Stephane Eranian
2010-06-18 4:22 ` Tom Zanussi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox