* [PATCH] fujitsu-laptop: make needlessly global symbols static
@ 2010-07-08 1:49 Axel Lin
2010-07-08 23:07 ` Jonathan Woithe
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-07-08 1:49 UTC (permalink / raw)
To: linux-kernel
Cc: Jonathan Woithe, Matthew Garrett, Andrew Morton, Stefani Seibold,
Andi Kleen, platform-driver-x86
The following symbols are needlessly defined global:
logolamp_led
kblamps_led
This patch makes the symbols static.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/platform/x86/fujitsu-laptop.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index e325aeb..a758d59 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -182,7 +182,7 @@ static enum led_brightness logolamp_get(struct led_classdev *cdev);
static void logolamp_set(struct led_classdev *cdev,
enum led_brightness brightness);
-struct led_classdev logolamp_led = {
+static struct led_classdev logolamp_led = {
.name = "fujitsu::logolamp",
.brightness_get = logolamp_get,
.brightness_set = logolamp_set
@@ -192,7 +192,7 @@ static enum led_brightness kblamps_get(struct led_classdev *cdev);
static void kblamps_set(struct led_classdev *cdev,
enum led_brightness brightness);
-struct led_classdev kblamps_led = {
+static struct led_classdev kblamps_led = {
.name = "fujitsu::kblamps",
.brightness_get = kblamps_get,
.brightness_set = kblamps_set
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fujitsu-laptop: make needlessly global symbols static
2010-07-08 1:49 [PATCH] fujitsu-laptop: make needlessly global symbols static Axel Lin
@ 2010-07-08 23:07 ` Jonathan Woithe
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Woithe @ 2010-07-08 23:07 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jonathan Woithe, Matthew Garrett, Andrew Morton,
Stefani Seibold, Andi Kleen, platform-driver-x86
Looks fine to me.
Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
> The following symbols are needlessly defined global:
>
> logolamp_led
> kblamps_led
>
> This patch makes the symbols static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index e325aeb..a758d59 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -182,7 +182,7 @@ static enum led_brightness logolamp_get(struct led_classdev *cdev);
> static void logolamp_set(struct led_classdev *cdev,
> enum led_brightness brightness);
>
> -struct led_classdev logolamp_led = {
> +static struct led_classdev logolamp_led = {
> .name = "fujitsu::logolamp",
> .brightness_get = logolamp_get,
> .brightness_set = logolamp_set
> @@ -192,7 +192,7 @@ static enum led_brightness kblamps_get(struct led_classdev *cdev);
> static void kblamps_set(struct led_classdev *cdev,
> enum led_brightness brightness);
>
> -struct led_classdev kblamps_led = {
> +static struct led_classdev kblamps_led = {
> .name = "fujitsu::kblamps",
> .brightness_get = kblamps_get,
> .brightness_set = kblamps_set
> --
> 1.5.4.3
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-08 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-08 1:49 [PATCH] fujitsu-laptop: make needlessly global symbols static Axel Lin
2010-07-08 23:07 ` Jonathan Woithe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox