public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions
@ 2010-07-12  1:15 Axel Lin
  2010-07-22 15:11 ` Matthew Garrett
  0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2010-07-12  1:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Corentin Chary, Matthew Garrett, Andrew Morton, Alan Jenkins,
	acpi4asus-user, platform-driver-x86

The hotplug_disabled module parameter is determinated at the module load time.
Change the value after the module is loaded does not make sense and has
no effect at all, thus set the permissions to 0444 instead of 0644.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/platform/x86/eeepc-laptop.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 0306174..6b8e062 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -53,7 +53,7 @@ MODULE_LICENSE("GPL");
 
 static bool hotplug_disabled;
 
-module_param(hotplug_disabled, bool, 0644);
+module_param(hotplug_disabled, bool, 0444);
 MODULE_PARM_DESC(hotplug_disabled,
 		 "Disable hotplug for wireless device. "
 		 "If your laptop need that, please report to "
-- 
1.5.4.3




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions
  2010-07-12  1:15 [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions Axel Lin
@ 2010-07-22 15:11 ` Matthew Garrett
  2010-07-23  0:45   ` Axel Lin
  0 siblings, 1 reply; 3+ messages in thread
From: Matthew Garrett @ 2010-07-22 15:11 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, platform-driver-x86

I think I've got all of your patches merged now, but let me know if I've 
missed any. They should be in my linux-next branch.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] eeepc-laptop: fix hotplug_disabled module_param  permissions
  2010-07-22 15:11 ` Matthew Garrett
@ 2010-07-23  0:45   ` Axel Lin
  0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2010-07-23  0:45 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-kernel, platform-driver-x86

2010/7/22 Matthew Garrett <mjg59@srcf.ucam.org>:
> I think I've got all of your patches merged now, but let me know if I've
> missed any. They should be in my linux-next branch.

hi Matthew,
Thanks for merging the patches.

Below 3 patches are missing:
[PATCH] asus-laptop: fix asus_input_init error path
        http://lkml.org/lkml/2010/7/5/21
[PATCH] dell-laptop: make dell_laptop_i8042_filter() static
        http://lkml.org/lkml/2010/7/5/69
[PATCH] msi-wmi: make needlessly global symbols static
        http://lkml.org/lkml/2010/7/8/66

Regards,
Axel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-07-23  0:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-12  1:15 [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions Axel Lin
2010-07-22 15:11 ` Matthew Garrett
2010-07-23  0:45   ` Axel Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox