* [PATCH] tc6393xb: fix wrong goto labels for error handling
@ 2010-08-03 3:10 Axel Lin
2010-08-03 10:33 ` Samuel Ortiz
2010-08-03 13:45 ` Ian Molton
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2010-08-03 3:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Ortiz, Ian Molton
This patch corrects the error handling path.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tc6393xb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
index fcf9068..ef6c42c 100644
--- a/drivers/mfd/tc6393xb.c
+++ b/drivers/mfd/tc6393xb.c
@@ -732,9 +732,9 @@ err_gpio_add:
if (tc6393xb->gpio.base != -1)
temp = gpiochip_remove(&tc6393xb->gpio);
tcpd->disable(dev);
-err_clk_enable:
- clk_disable(tc6393xb->clk);
err_enable:
+ clk_disable(tc6393xb->clk);
+err_clk_enable:
iounmap(tc6393xb->scr);
err_ioremap:
release_resource(&tc6393xb->rscr);
--
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tc6393xb: fix wrong goto labels for error handling
2010-08-03 3:10 [PATCH] tc6393xb: fix wrong goto labels for error handling Axel Lin
@ 2010-08-03 10:33 ` Samuel Ortiz
2010-08-03 13:48 ` Ian Molton
2010-08-03 13:45 ` Ian Molton
1 sibling, 1 reply; 4+ messages in thread
From: Samuel Ortiz @ 2010-08-03 10:33 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Ian Molton
On Tue, Aug 03, 2010 at 11:10:41AM +0800, Axel Lin wrote:
> This patch corrects the error handling path.
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tc6393xb: fix wrong goto labels for error handling
2010-08-03 3:10 [PATCH] tc6393xb: fix wrong goto labels for error handling Axel Lin
2010-08-03 10:33 ` Samuel Ortiz
@ 2010-08-03 13:45 ` Ian Molton
1 sibling, 0 replies; 4+ messages in thread
From: Ian Molton @ 2010-08-03 13:45 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Samuel Ortiz
Acked-by: Ian Molton <ian.molton@mnementh.co.uk>
On 3 August 2010 04:10, Axel Lin <axel.lin@gmail.com> wrote:
> This patch corrects the error handling path.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/tc6393xb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index fcf9068..ef6c42c 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -732,9 +732,9 @@ err_gpio_add:
> if (tc6393xb->gpio.base != -1)
> temp = gpiochip_remove(&tc6393xb->gpio);
> tcpd->disable(dev);
> -err_clk_enable:
> - clk_disable(tc6393xb->clk);
> err_enable:
> + clk_disable(tc6393xb->clk);
> +err_clk_enable:
> iounmap(tc6393xb->scr);
> err_ioremap:
> release_resource(&tc6393xb->rscr);
> --
> 1.5.4.3
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tc6393xb: fix wrong goto labels for error handling
2010-08-03 10:33 ` Samuel Ortiz
@ 2010-08-03 13:48 ` Ian Molton
0 siblings, 0 replies; 4+ messages in thread
From: Ian Molton @ 2010-08-03 13:48 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel
Whoops, didnt see your message Samuel :)
On 3 August 2010 11:33, Samuel Ortiz <sameo@linux.intel.com> wrote:
> On Tue, Aug 03, 2010 at 11:10:41AM +0800, Axel Lin wrote:
>> This patch corrects the error handling path.
> Applied, thanks.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-03 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03 3:10 [PATCH] tc6393xb: fix wrong goto labels for error handling Axel Lin
2010-08-03 10:33 ` Samuel Ortiz
2010-08-03 13:48 ` Ian Molton
2010-08-03 13:45 ` Ian Molton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox