* [PATCH 2/4] mfd: tps6507x - fix incorrect kfree(i2c) in i2c_driver probe callback handler
@ 2010-08-09 6:49 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2010-08-09 6:49 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Ortiz, Todd Fischer, Mark Brown
The i2c_client received in probe() should not be kfree()'d.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tps6507x.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
index d859dff..fc01976 100644
--- a/drivers/mfd/tps6507x.c
+++ b/drivers/mfd/tps6507x.c
@@ -89,10 +89,8 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c,
int ret = 0;
tps6507x = kzalloc(sizeof(struct tps6507x_dev), GFP_KERNEL);
- if (tps6507x == NULL) {
- kfree(i2c);
+ if (tps6507x == NULL)
return -ENOMEM;
- }
i2c_set_clientdata(i2c, tps6507x);
tps6507x->dev = &i2c->dev;
--
1.5.4.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-09 6:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 6:49 [PATCH 2/4] mfd: tps6507x - fix incorrect kfree(i2c) in i2c_driver probe callback handler Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox