From: Peter Zijlstra <peterz@infradead.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Robert Richter <robert.richter@amd.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Lin Ming <ming.m.lin@intel.com>, Ingo Molnar <mingo@elte.hu>,
"fweisbec@gmail.com" <fweisbec@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Huang, Ying" <ying.huang@intel.com>,
Yinghai Lu <yinghai@kernel.org>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs
Date: Fri, 20 Aug 2010 10:50:16 +0200 [thread overview]
Message-ID: <1282294216.2605.664.camel@laptop> (raw)
In-Reply-To: <20100819215803.GZ4879@redhat.com>
On Thu, 2010-08-19 at 17:58 -0400, Don Zickus wrote:
> On Thu, Aug 19, 2010 at 04:27:13PM +0200, Peter Zijlstra wrote:
> > x86_pmu.drain_pebs(regs);
> > + }
> >
> > for_each_set_bit(bit, (unsigned long *)&status, X86_PMC_IDX_MAX) {
> > struct perf_event *event = cpuc->events[bit];
> >
> > + handled++;
> > +
> > if (!test_bit(bit, cpuc->active_mask))
> > continue;
>
> Sorry I didn't notice this earlier, but I think you want that handled++
> after the if(..) continue pieces. Otherwise you will always have a number
> >1. :-)
Only if there's any remaining set bits in the overflow status reg,
right?
But if we want to be paranoid, we should also check if the event that
generated the overflow actually had the INT flag enabled, I guess ;-)
next prev parent reply other threads:[~2010-08-20 8:50 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 9:21 A question of perf NMI handler Lin Ming
2010-08-04 9:50 ` Peter Zijlstra
2010-08-04 10:01 ` Robert Richter
2010-08-04 10:24 ` Peter Zijlstra
2010-08-04 10:29 ` Robert Richter
2010-08-04 14:00 ` Don Zickus
2010-08-04 14:11 ` Peter Zijlstra
2010-08-04 14:52 ` Don Zickus
2010-08-04 15:02 ` Peter Zijlstra
2010-08-04 15:18 ` Cyrill Gorcunov
2010-08-04 15:50 ` Don Zickus
2010-08-04 16:10 ` Cyrill Gorcunov
2010-08-04 16:20 ` Don Zickus
2010-08-04 16:39 ` Cyrill Gorcunov
2010-08-04 18:48 ` Robert Richter
2010-08-04 19:22 ` Andi Kleen
2010-08-04 19:26 ` Cyrill Gorcunov
2010-08-06 6:52 ` Robert Richter
2010-08-06 14:21 ` Don Zickus
2010-08-09 19:48 ` [PATCH] perf, x86: try to handle unknown nmis with running perfctrs Robert Richter
2010-08-09 20:02 ` Cyrill Gorcunov
2010-08-10 7:42 ` Robert Richter
2010-08-10 16:16 ` Cyrill Gorcunov
2010-08-10 16:41 ` Robert Richter
2010-08-10 17:24 ` Cyrill Gorcunov
2010-08-10 19:05 ` Robert Richter
2010-08-10 19:24 ` Cyrill Gorcunov
2010-08-12 13:24 ` Robert Richter
2010-08-12 14:31 ` Cyrill Gorcunov
2010-08-10 20:48 ` Don Zickus
2010-08-11 2:44 ` Frederic Weisbecker
2010-08-11 11:10 ` Robert Richter
2010-08-11 12:44 ` Don Zickus
2010-08-11 14:03 ` Robert Richter
2010-08-11 14:32 ` Don Zickus
2010-08-13 4:37 ` Frederic Weisbecker
2010-08-13 8:22 ` Robert Richter
2010-08-14 1:28 ` Frederic Weisbecker
2010-08-14 2:29 ` Robert Richter
2010-08-11 12:39 ` Don Zickus
2010-08-11 3:19 ` Huang Ying
2010-08-11 12:36 ` Don Zickus
2010-08-16 14:37 ` Peter Zijlstra
2010-08-11 22:00 ` [PATCH -v2] " Robert Richter
2010-08-12 13:10 ` Robert Richter
2010-08-12 18:21 ` Don Zickus
2010-08-16 7:37 ` Robert Richter
2010-08-12 13:52 ` Don Zickus
2010-08-13 4:25 ` Frederic Weisbecker
2010-08-16 14:48 ` Peter Zijlstra
2010-08-16 16:27 ` Cyrill Gorcunov
2010-08-16 17:16 ` Robert Richter
2010-08-16 19:06 ` Cyrill Gorcunov
2010-08-16 19:13 ` Peter Zijlstra
2010-08-16 19:18 ` Cyrill Gorcunov
2010-08-16 22:55 ` Robert Richter
2010-08-17 15:23 ` Cyrill Gorcunov
2010-08-17 15:22 ` [PATCH -v3] " Robert Richter
2010-08-17 16:17 ` Cyrill Gorcunov
2010-08-19 10:45 ` Peter Zijlstra
2010-08-19 12:39 ` Robert Richter
2010-08-19 14:12 ` Don Zickus
2010-08-19 14:27 ` Peter Zijlstra
2010-08-19 15:20 ` Don Zickus
2010-08-19 17:43 ` Cyrill Gorcunov
2010-08-19 17:53 ` Peter Zijlstra
2010-08-19 21:58 ` Don Zickus
2010-08-20 8:50 ` Peter Zijlstra [this message]
2010-08-20 1:50 ` Don Zickus
2010-08-20 8:16 ` Ingo Molnar
2010-08-20 10:04 ` Peter Zijlstra
2010-08-20 10:30 ` Cyrill Gorcunov
2010-08-20 12:39 ` Don Zickus
2010-08-20 13:27 ` Ingo Molnar
2010-08-20 13:51 ` Don Zickus
2010-08-20 14:17 ` Ingo Molnar
2010-08-20 20:45 ` Cyrill Gorcunov
2010-08-24 21:48 ` Don Zickus
2010-08-20 8:36 ` Robert Richter
2010-08-20 14:17 ` [tip:perf/urgent] perf, x86: Fix handle_irq return values tip-bot for Peter Zijlstra
2010-08-20 14:17 ` [tip:perf/urgent] perf, x86: Try to handle unknown nmis with an enabled PMU tip-bot for Robert Richter
2010-08-06 15:35 ` A question of perf NMI handler Andi Kleen
2010-08-04 15:45 ` Don Zickus
2010-08-06 15:37 ` Andi Kleen
2010-08-04 13:54 ` Don Zickus
-- strict thread matches above, loose matches on Subject: below --
2010-08-20 15:05 [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs Don Zickus
2010-08-20 15:25 ` Ingo Molnar
2010-08-23 8:53 ` Ingo Molnar
2010-08-24 16:22 ` Cyrill Gorcunov
2010-08-24 17:09 ` Robert Richter
2010-08-24 17:20 ` Cyrill Gorcunov
2010-08-24 17:21 ` Cyrill Gorcunov
2010-08-24 17:15 ` Robert Richter
2010-08-24 17:28 ` Cyrill Gorcunov
2010-08-24 18:46 ` Don Zickus
2010-08-24 18:54 ` Cyrill Gorcunov
2010-08-24 19:52 ` Cyrill Gorcunov
2010-08-24 20:27 ` Don Zickus
2010-08-24 20:40 ` Cyrill Gorcunov
2010-08-25 23:52 ` Frederic Weisbecker
2010-08-26 9:11 ` Cyrill Gorcunov
2010-08-25 10:20 ` Robert Richter
2010-08-26 21:14 ` Don Zickus
2010-08-27 7:51 ` Robert Richter
2010-08-27 13:39 ` Don Zickus
2010-08-27 8:10 ` Robert Richter
2010-08-27 13:44 ` Don Zickus
2010-08-27 14:05 ` Robert Richter
2010-08-27 15:05 ` Don Zickus
2010-08-27 15:48 ` Robert Richter
2010-08-27 18:57 ` Don Zickus
2010-08-27 19:00 ` Yinghai Lu
2010-08-27 19:33 ` Robert Richter
2010-08-25 9:48 ` Robert Richter
2010-08-25 10:41 ` Ingo Molnar
2010-08-25 11:00 ` Ingo Molnar
2010-08-25 20:11 ` Don Zickus
2010-08-25 20:24 ` Cyrill Gorcunov
2010-08-25 21:20 ` Don Zickus
2010-08-25 21:36 ` Cyrill Gorcunov
2010-08-26 9:00 ` Robert Richter
2010-08-26 9:18 ` Cyrill Gorcunov
2010-08-26 14:31 ` Don Zickus
2010-08-26 15:22 ` Don Zickus
2010-08-26 15:34 ` Cyrill Gorcunov
2010-08-26 16:40 ` Don Zickus
2010-08-26 18:02 ` Cyrill Gorcunov
2010-08-27 7:57 ` Robert Richter
2010-08-27 8:11 ` Peter Zijlstra
2010-08-27 8:31 ` Robert Richter
2010-08-25 11:02 ` Robert Richter
2010-08-25 11:19 ` Ingo Molnar
2010-08-20 23:31 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282294216.2605.664.camel@laptop \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox