[PATCH] SLUB: Fix memory hotplug with !NUMA

[PATCH] SLUB: Fix memory hotplug with !NUMA

[Pekka Enberg]

This patch fixes the following build breakage when memory hotplug is enabled on
UMA configurations:

  /home/test/linux-2.6/mm/slub.c: In function 'kmem_cache_init':
  /home/test/linux-2.6/mm/slub.c:3031:2: error: 'slab_memory_callback'
  undeclared (first use in this function)
  /home/test/linux-2.6/mm/slub.c:3031:2: note: each undeclared
  identifier is reported only once for each function it appears in
  make[2]: *** [mm/slub.o] Error 1
  make[1]: *** [mm] Error 2
  make: *** [sub-make] Error 2

Reported-by: Zimny Lech <napohybelskurwysynom2010@gmail.com>
Cc: Christoph Lameter <cl@linux.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index fe536d3..8fd5401 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2851,7 +2851,7 @@ int kmem_cache_shrink(struct kmem_cache *s)
 }
 EXPORT_SYMBOL(kmem_cache_shrink);
 
-#if defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)
+#if defined(CONFIG_MEMORY_HOTPLUG)
 static int slab_mem_going_offline_callback(void *arg)
 {
 	struct kmem_cache *s;
-- 
1.6.3.3

Re: [PATCH] SLUB: Fix memory hotplug with !NUMA

[Christoph Lameter]

On Wed, 6 Oct 2010, Pekka Enberg wrote:

> This patch fixes the following build breakage when memory hotplug is enabled on
> UMA configurations:

Hum? That works?

> diff --git a/mm/slub.c b/mm/slub.c
> index fe536d3..8fd5401 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2851,7 +2851,7 @@ int kmem_cache_shrink(struct kmem_cache *s)
>  }
>  EXPORT_SYMBOL(kmem_cache_shrink);
>
> -#if defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)
> +#if defined(CONFIG_MEMORY_HOTPLUG)
>  static int slab_mem_going_offline_callback(void *arg)
>  {
>  	struct kmem_cache *s;
>

Acked-by: Christoph Lameter <cl@linux.com>

Re: [PATCH] SLUB: Fix memory hotplug with !NUMA [OT[

[el es]

Pekka Enberg <penberg <at> kernel.org> writes:


> Reported-by: Zimny Lech <napohybelskurwysynom2010 <at> gmail.com>

Sorry for those not familiar with Polish language :

- the email address username contains explicit content by Polish language
standards (rough translation : kill the f**kers [or m-f])

- the name and surname is not likely to be real, it looks like nickname to me
(background : Zimny means cold; yes it may be also used as surname; Lech may be
a first name, but is also a name of a brand of beer made in Poland - together
the phrase 'Zimny Lech' I have seen used in a TV advertisement for that brewery
and its other (billboards etc) media. )

Just FYI.

Lukasz

Re: [PATCH] SLUB: Fix memory hotplug with !NUMA [OT[

[Pekka Enberg]

(Please don't trim the CC lists.)

On Thu, Oct 7, 2010 at 1:44 PM, el es <el.es.cr@gmail.com> wrote:
> Pekka Enberg <penberg <at> kernel.org> writes:
>> Reported-by: Zimny Lech <napohybelskurwysynom2010 <at> gmail.com>
>
> Sorry for those not familiar with Polish language :
>
> - the email address username contains explicit content by Polish language
> standards (rough translation : kill the f**kers [or m-f])

Heh.

> - the name and surname is not likely to be real, it looks like nickname to me
> (background : Zimny means cold; yes it may be also used as surname; Lech may be
> a first name, but is also a name of a brand of beer made in Poland - together
> the phrase 'Zimny Lech' I have seen used in a TV advertisement for that brewery
> and its other (billboards etc) media. )
>
> Just FYI.

Well, as long as it's a valid e-mail address and it's not a sign-off,
I don't really mind. If people don't want credit for their work (like
reporting bugs or testing patches), it's their choice.

                        Pekka