public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Lennart Poettering <lennart@poettering.net>,
	stable@kernel.org
Subject: Re: [PATCH] sched: drop all load weight manipulation for RT tasks
Date: Tue, 12 Oct 2010 11:31:16 +0200	[thread overview]
Message-ID: <1286875876.29097.24.camel@twins> (raw)
In-Reply-To: <1286807811-10568-1-git-send-email-linus.walleij@stericsson.com>

On Mon, 2010-10-11 at 16:36 +0200, Linus Walleij wrote:
> Load weights are for the CFS, they do not belong in the RT
> task. This makes all RT scheduling classes leave the
> CFS weights alone.
> 
> This fixes a real bug as well: I noticed the following
> phonomena: a process elevated to SCHED_RR forks with
> SCHED_RESET_ON_FORK set, and the child is indeed SCHED_OTHER,
> and the niceval is indeed reset to 0. However the
> weight inserted by set_load_weight() remains at 0. giving the
> task insignificat priority.
> 
> With this fix, the weight is reset to what the task had before
> being elevated to SCHED_RR/SCHED_FIFO.
> 
> Cc: Lennart Poettering <lennart@poettering.net>
> Cc: stable@kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>

Thanks, queued it up, we'll see if anything explodes ;-)

  reply	other threads:[~2010-10-12  9:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 14:36 [PATCH] sched: drop all load weight manipulation for RT tasks Linus Walleij
2010-10-12  9:31 ` Peter Zijlstra [this message]
2010-10-18 19:16 ` [tip:sched/core] sched: Drop " tip-bot for Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286875876.29097.24.camel@twins \
    --to=peterz@infradead.org \
    --cc=lennart@poettering.net \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox