* [PATCH 1/1] crypto: api.c adding kernel-doc comments
@ 2010-11-04 17:07 Mark Allyn
2010-11-04 17:22 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Mark Allyn @ 2010-11-04 17:07 UTC (permalink / raw)
To: linux-kernel, linux-crypto; +Cc: Mark Allyn
Add comments to crypto_alg_lookup and crypto_larval_lookup
I am re-submitting this due to errors
Signed-off-by: Mark A. Allyn <mark.a.allyn@intel.com>
---
crypto/api.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/crypto/api.c b/crypto/api.c
index 033a714..71c389d 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -193,6 +193,15 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
return alg;
}
+/**
+ * crypto_alg_lookup() return crypto_alg structure for an algorithm
+ * @name: text string containing name of algorithm
+ * @type: crypto type (defined at about line 31 of
+ * include/linux/crypto.h)
+ * @mask: mask of allowable crypto types (use or'd list
+ * of types as defined at about line 31 of
+ * include/linux/crypto.h)
+ */
struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
{
struct crypto_alg *alg;
@@ -205,6 +214,16 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
}
EXPORT_SYMBOL_GPL(crypto_alg_lookup);
+/**
+ * crypto_alg_larval lookup() return large value (larval) crypto_alg
+ * structure for an algorithm
+ * @name: text string containing name of algorithm
+ * @type: crypto type (defined at about line 31 of
+ * include/linux/crypto.h)
+ * @mask: mask of allowable crypto types (use or'd list
+ * of types as defined at about line 31 of
+ * include/linux/crypto.h)
+ */
struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
{
struct crypto_alg *alg;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] crypto: api.c adding kernel-doc comments
2010-11-04 17:07 [PATCH 1/1] crypto: api.c adding kernel-doc comments Mark Allyn
@ 2010-11-04 17:22 ` Randy Dunlap
2010-11-04 17:25 ` Allyn, Mark A
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2010-11-04 17:22 UTC (permalink / raw)
To: Mark Allyn; +Cc: linux-kernel, linux-crypto
On Thu, 4 Nov 2010 10:07:22 -0700 Mark Allyn wrote:
> Add comments to crypto_alg_lookup and crypto_larval_lookup
>
> I am re-submitting this due to errors
>
> Signed-off-by: Mark A. Allyn <mark.a.allyn@intel.com>
> ---
> crypto/api.c | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/crypto/api.c b/crypto/api.c
> index 033a714..71c389d 100644
> --- a/crypto/api.c
> +++ b/crypto/api.c
> @@ -193,6 +193,15 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
> return alg;
> }
>
> +/**
> + * crypto_alg_lookup() return crypto_alg structure for an algorithm
needs hyphen between function name and "return".
> + * @name: text string containing name of algorithm
> + * @type: crypto type (defined at about line 31 of
> + * include/linux/crypto.h)
> + * @mask: mask of allowable crypto types (use or'd list
> + * of types as defined at about line 31 of
> + * include/linux/crypto.h)
drop the line numbers...
> + */
> struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> {
> struct crypto_alg *alg;
> @@ -205,6 +214,16 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> }
> EXPORT_SYMBOL_GPL(crypto_alg_lookup);
>
> +/**
> + * crypto_alg_larval lookup() return large value (larval) crypto_alg
* crypto_larval_lookup() - return large value (larval) crypto_alg
> + * structure for an algorithm
> + * @name: text string containing name of algorithm
> + * @type: crypto type (defined at about line 31 of
> + * include/linux/crypto.h)
> + * @mask: mask of allowable crypto types (use or'd list
> + * of types as defined at about line 31 of
> + * include/linux/crypto.h)
> + */
drop the line numbers.
> struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
> {
> struct crypto_alg *alg;
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 1/1] crypto: api.c adding kernel-doc comments
2010-11-04 17:22 ` Randy Dunlap
@ 2010-11-04 17:25 ` Allyn, Mark A
2010-11-04 17:30 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Allyn, Mark A @ 2010-11-04 17:25 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
This is my first time in attempting to patch documentation. Shall I follow your suggestions by submitting a patch that depends on this patch or shall I submit the whole thing again with the corrections?
Mark
-----Original Message-----
From: Randy Dunlap [mailto:rdunlap@xenotime.net]
Sent: Thursday, November 04, 2010 10:22 AM
To: Allyn, Mark A
Cc: linux-kernel@vger.kernel.org; linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/1] crypto: api.c adding kernel-doc comments
On Thu, 4 Nov 2010 10:07:22 -0700 Mark Allyn wrote:
> Add comments to crypto_alg_lookup and crypto_larval_lookup
>
> I am re-submitting this due to errors
>
> Signed-off-by: Mark A. Allyn <mark.a.allyn@intel.com>
> ---
> crypto/api.c | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/crypto/api.c b/crypto/api.c
> index 033a714..71c389d 100644
> --- a/crypto/api.c
> +++ b/crypto/api.c
> @@ -193,6 +193,15 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
> return alg;
> }
>
> +/**
> + * crypto_alg_lookup() return crypto_alg structure for an algorithm
needs hyphen between function name and "return".
> + * @name: text string containing name of algorithm
> + * @type: crypto type (defined at about line 31 of
> + * include/linux/crypto.h)
> + * @mask: mask of allowable crypto types (use or'd list
> + * of types as defined at about line 31 of
> + * include/linux/crypto.h)
drop the line numbers...
> + */
> struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> {
> struct crypto_alg *alg;
> @@ -205,6 +214,16 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> }
> EXPORT_SYMBOL_GPL(crypto_alg_lookup);
>
> +/**
> + * crypto_alg_larval lookup() return large value (larval) crypto_alg
* crypto_larval_lookup() - return large value (larval) crypto_alg
> + * structure for an algorithm
> + * @name: text string containing name of algorithm
> + * @type: crypto type (defined at about line 31 of
> + * include/linux/crypto.h)
> + * @mask: mask of allowable crypto types (use or'd list
> + * of types as defined at about line 31 of
> + * include/linux/crypto.h)
> + */
drop the line numbers.
> struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
> {
> struct crypto_alg *alg;
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] crypto: api.c adding kernel-doc comments
2010-11-04 17:25 ` Allyn, Mark A
@ 2010-11-04 17:30 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2010-11-04 17:30 UTC (permalink / raw)
To: Allyn, Mark A; +Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
On Thu, 4 Nov 2010 11:25:06 -0600 Allyn, Mark A wrote:
> This is my first time in attempting to patch documentation. Shall I follow your suggestions by submitting a patch that depends on this patch or shall I submit the whole thing again with the corrections?
>
Hi Mark,
If your patch was already merged somewhere (even in an intermediate tree),
you should just send a partial/update patch, but in this case, since it hasn't
been merged anywhere (that I know of), I recommend sending a complete new patch.
Thanks.
>
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> Sent: Thursday, November 04, 2010 10:22 AM
> To: Allyn, Mark A
> Cc: linux-kernel@vger.kernel.org; linux-crypto@vger.kernel.org
> Subject: Re: [PATCH 1/1] crypto: api.c adding kernel-doc comments
>
> On Thu, 4 Nov 2010 10:07:22 -0700 Mark Allyn wrote:
>
> > Add comments to crypto_alg_lookup and crypto_larval_lookup
> >
> > I am re-submitting this due to errors
> >
> > Signed-off-by: Mark A. Allyn <mark.a.allyn@intel.com>
> > ---
> > crypto/api.c | 19 +++++++++++++++++++
> > 1 files changed, 19 insertions(+), 0 deletions(-)
> >
> > diff --git a/crypto/api.c b/crypto/api.c
> > index 033a714..71c389d 100644
> > --- a/crypto/api.c
> > +++ b/crypto/api.c
> > @@ -193,6 +193,15 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
> > return alg;
> > }
> >
> > +/**
> > + * crypto_alg_lookup() return crypto_alg structure for an algorithm
>
> needs hyphen between function name and "return".
>
> > + * @name: text string containing name of algorithm
> > + * @type: crypto type (defined at about line 31 of
> > + * include/linux/crypto.h)
> > + * @mask: mask of allowable crypto types (use or'd list
> > + * of types as defined at about line 31 of
> > + * include/linux/crypto.h)
>
> drop the line numbers...
>
> > + */
> > struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> > {
> > struct crypto_alg *alg;
> > @@ -205,6 +214,16 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> > }
> > EXPORT_SYMBOL_GPL(crypto_alg_lookup);
> >
> > +/**
> > + * crypto_alg_larval lookup() return large value (larval) crypto_alg
>
> * crypto_larval_lookup() - return large value (larval) crypto_alg
>
>
> > + * structure for an algorithm
> > + * @name: text string containing name of algorithm
> > + * @type: crypto type (defined at about line 31 of
> > + * include/linux/crypto.h)
> > + * @mask: mask of allowable crypto types (use or'd list
> > + * of types as defined at about line 31 of
> > + * include/linux/crypto.h)
> > + */
>
> drop the line numbers.
>
> > struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
> > {
> > struct crypto_alg *alg;
> > --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-04 17:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-04 17:07 [PATCH 1/1] crypto: api.c adding kernel-doc comments Mark Allyn
2010-11-04 17:22 ` Randy Dunlap
2010-11-04 17:25 ` Allyn, Mark A
2010-11-04 17:30 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox