* [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h
@ 2010-11-10 11:31 Catalin Marinas
2010-11-10 12:33 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Catalin Marinas @ 2010-11-10 11:31 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Peter Zijlstra
Commit 3e4d3af introduced the kmap_atomic_idx_push() function which
warns on in_irq() with CONFIG_DEBUG_HIGHMEM enabled. This patch includes
linux/hardirq.h for the in_irq definition.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Please ignore if the patch has already been posted.
include/linux/highmem.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/highmem.h b/include/linux/highmem.h
index e913819..b676c58 100644
--- a/include/linux/highmem.h
+++ b/include/linux/highmem.h
@@ -5,6 +5,7 @@
#include <linux/kernel.h>
#include <linux/mm.h>
#include <linux/uaccess.h>
+#include <linux/hardirq.h>
#include <asm/cacheflush.h>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h
2010-11-10 11:31 [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h Catalin Marinas
@ 2010-11-10 12:33 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2010-11-10 12:33 UTC (permalink / raw)
To: Catalin Marinas; +Cc: linux-kernel, Andrew Morton
On Wed, 2010-11-10 at 11:31 +0000, Catalin Marinas wrote:
> Commit 3e4d3af introduced the kmap_atomic_idx_push() function which
> warns on in_irq() with CONFIG_DEBUG_HIGHMEM enabled. This patch includes
> linux/hardirq.h for the in_irq definition.
Ah, indeed. The whole KS/LPC thing made me forget about this issue.
Somehow it only triggered on ARM.
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> include/linux/highmem.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index e913819..b676c58 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -5,6 +5,7 @@
> #include <linux/kernel.h>
> #include <linux/mm.h>
> #include <linux/uaccess.h>
> +#include <linux/hardirq.h>
>
> #include <asm/cacheflush.h>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-10 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-10 11:31 [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h Catalin Marinas
2010-11-10 12:33 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox