public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <jaxboe@fusionio.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] generic-ipi: add lock context annotations
Date: Tue, 23 Nov 2010 12:19:50 +0900	[thread overview]
Message-ID: <1290482390.1857.26.camel@leonhard> (raw)
In-Reply-To: <1290430003.2072.101.camel@laptop>

2010-11-22 (월), 13:46 +0100, Peter Zijlstra:
> On Mon, 2010-11-22 at 16:33 +0900, Namhyung Kim wrote:
> > The ipi_call_[un]lock[_irq] functions grab/release a spin lock
> > but were missing proper annotations. Add it.
> 
> I really have to ask why bother? Why not add some smarts to whatever
> uses these annotations?

I just thought that removing bogus warnings from sparse helps us focus
on real issues when using it. Currently sparse emits too many messages
and some (many?) of them might be removed trivially (or by adding bit of
ugliness. :( )

BTW, I didn't get what you mean about "some smarts". Could you explain
them little more?

Thanks.

-- 
Regards,
Namhyung Kim



  reply	other threads:[~2010-11-23  3:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22  7:33 [PATCH] generic-ipi: add lock context annotations Namhyung Kim
2010-11-22 12:46 ` Peter Zijlstra
2010-11-23  3:19   ` Namhyung Kim [this message]
2010-11-23  8:49     ` Jens Axboe
2010-11-23  9:40       ` Dan Carpenter
2010-11-24  5:24         ` Namhyung Kim
2010-11-24  5:43           ` Dan Carpenter
2010-11-24 14:29             ` Namhyung Kim
2010-11-24 14:33               ` Peter Zijlstra
2010-11-24 15:03                 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290482390.1857.26.camel@leonhard \
    --to=namhyung@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox