From: Namhyung Kim <namhyung@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dan Carpenter <error27@gmail.com>,
Jens Axboe <jaxboe@fusionio.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] generic-ipi: add lock context annotations
Date: Thu, 25 Nov 2010 00:03:41 +0900 [thread overview]
Message-ID: <1290611021.1675.26.camel@leonhard> (raw)
In-Reply-To: <1290609214.2072.476.camel@laptop>
2010-11-24 (수), 15:33 +0100, Peter Zijlstra:
> Aside from complain, do these sparse annotations ever catch a bug?
>
Dunno, sorry. I only have very limited experience of kernel development.
> I don't particularly like the __acquire() and __release() tags, but
> could possibly live with them when they only need to be in headers, but
> the __cond_lock() crap is just revolting.
Yes, it's very ugly. But some people told me it's a better way to
describe conditional lock acquisition from complicated functions. It
helped sparse recognize normal usage of such functions and suppress
warnings but only warn themselves.
--
Regards,
Namhyung Kim
prev parent reply other threads:[~2010-11-24 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 7:33 [PATCH] generic-ipi: add lock context annotations Namhyung Kim
2010-11-22 12:46 ` Peter Zijlstra
2010-11-23 3:19 ` Namhyung Kim
2010-11-23 8:49 ` Jens Axboe
2010-11-23 9:40 ` Dan Carpenter
2010-11-24 5:24 ` Namhyung Kim
2010-11-24 5:43 ` Dan Carpenter
2010-11-24 14:29 ` Namhyung Kim
2010-11-24 14:33 ` Peter Zijlstra
2010-11-24 15:03 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290611021.1675.26.camel@leonhard \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox