From: Lin Ming <ming.m.lin@intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH 3/3 v3] perf: Update perf tool to monitor uncore events
Date: Thu, 02 Dec 2010 13:20:38 +0800 [thread overview]
Message-ID: <1291267238.2405.315.camel@minggr.sh.intel.com> (raw)
Uncore events are monitored with raw events with "ru" prefix("u" for uncore).
Note that, per-task uncore event is not allowed.
$ ./perf stat -e ru0101 -- ls
No permission to collect stats.
Consider tweaking /proc/sys/kernel/perf_event_paranoid.
./perf stat -a -C 0 -e ru0101 -- ls
Performance counter stats for 'ls':
949585 raw 0x101
0.001741513 seconds time elapsed
TODO:
- Add a new sub-command for uncore events statistics.
For example, perf package -p <package-id> -e <event>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
tools/perf/util/parse-events.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 73215e7..81df119 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -278,7 +278,7 @@ const char *__event_name(int type, u64 config)
{
static char buf[32];
- if (type == PERF_TYPE_RAW) {
+ if (type == PERF_TYPE_RAW || type == PERF_TYPE_UNCORE) {
sprintf(buf, "raw 0x%llx", config);
return buf;
}
@@ -659,14 +659,20 @@ parse_raw_event(const char **strp, struct perf_event_attr *attr)
{
const char *str = *strp;
u64 config;
+ int uncore = 0;
int n;
if (*str != 'r')
return EVT_FAILED;
- n = hex2u64(str + 1, &config);
+ if (*(str+1) == 'u')
+ uncore = 1;
+ n = hex2u64(str + 1 + uncore, &config);
if (n > 0) {
- *strp = str + n + 1;
- attr->type = PERF_TYPE_RAW;
+ *strp = str + n + 1 + uncore;
+ if (!uncore)
+ attr->type = PERF_TYPE_RAW;
+ else
+ attr->type = PERF_TYPE_UNCORE;
attr->config = config;
return EVT_HANDLED;
}
--
1.5.3
next reply other threads:[~2010-12-02 5:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:20 Lin Ming [this message]
2010-12-14 1:28 ` [RFC PATCH 3/3 v3] perf: Update perf tool to monitor uncore events Corey Ashford
2010-12-14 2:15 ` Lin Ming
2010-12-14 12:33 ` Peter Zijlstra
2010-12-14 14:13 ` Andi Kleen
2010-12-15 17:14 ` Martin Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291267238.2405.315.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox