From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Carl Love <cel@linux.ibm.com>
Subject: Re: [RFC PATCH 3/3 v3] perf: Update perf tool to monitor uncore events
Date: Tue, 14 Dec 2010 13:33:27 +0100 [thread overview]
Message-ID: <1292330007.6803.1629.camel@twins> (raw)
In-Reply-To: <1292292908.10384.137.camel@minggr.sh.intel.com>
On Tue, 2010-12-14 at 10:15 +0800, Lin Ming wrote:
> > First of all, "uncore" is an x86-specific term and so it's not clear to
> > me if you meant for all arches to utilize this encoding for all "not
> > core but on the same die" events (IBM Power arch refers to this as
> > "nest" logic).
I don't think the x86 uncore matches the "not on core but on the same
die" definition. The x86-uncore thing is more like a memory controller
PMU (and since the memory controller is on die it is of course on die,
but its not just any random on-die thing).
The wire-speed thing has tons of special purpose 'cores' on die, each of
them having a PMU.
Using the sysfs stuff you could actually expose each individually.
> Yes, they are temporary solution. I use it to easily test uncore
> patches. Sorry I should mention that.
>
> sysfs is the final solution, but I'm not clear how the sysfs structures
> should be.
>
> As we discussed before,
>
> 1. Should we list all events under sysfs?
>
> /sys/devices/system/cpu/cpuN/events/event0
> ...
> /sys/devices/system/cpu/cpuN/events/eventN
>
> /sys/devices/system/node/nodeN/pmuN/events/event0
> ...
> /sys/devices/system/node/nodeN/pmuN/events/eventN
I'd not put _all_ events there, maybe a key few. Then again, Corey would
like to make all optional on module load or somesuch.
> 2. Or should we use a sysfs file to pass in raw config value?
That's not mutually exclusive with 1), the way I've implemented it is
that the sysfs event files provide the raw config values needed for that
event.
> /sys/devices/system/cpu/cpuN/raw
> /sys/devices/system/node/nodeN/pmuN/raw?
>
> 3. How will the additional attributes(needed by IBM PowerEN chip, etc)
> be passed in?
>From what I understood they all still fit in the single u64 config
field.
next prev parent reply other threads:[~2010-12-14 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:20 [RFC PATCH 3/3 v3] perf: Update perf tool to monitor uncore events Lin Ming
2010-12-14 1:28 ` Corey Ashford
2010-12-14 2:15 ` Lin Ming
2010-12-14 12:33 ` Peter Zijlstra [this message]
2010-12-14 14:13 ` Andi Kleen
2010-12-15 17:14 ` Martin Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292330007.6803.1629.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=cel@linux.ibm.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox