* [PATCH] ext4: reduce redundant check of '*options'
@ 2011-01-13 12:45 Simon Xu
0 siblings, 0 replies; only message in thread
From: Simon Xu @ 2011-01-13 12:45 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, Simon Xu
We don't need to check whether '*options' equals to ',' twice.
Signed-off-by: Simon Xu <xu.simon@oracle.com>
---
fs/ext4/super.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 29c80f6..5d8c173 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1350,13 +1350,13 @@ static ext4_fsblk_t get_sb_block(void **data)
options += 3;
/* TODO: use simple_strtoll with >32bit ext4 */
sb_block = simple_strtoul(options, &options, 0);
- if (*options && *options != ',') {
+ if (*options == ',') {
+ options++;
+ else if (*options) {
printk(KERN_ERR "EXT4-fs: Invalid sb specification: %s\n",
(char *) *data);
return 1;
}
- if (*options == ',')
- options++;
*data = (void *) options;
return sb_block;
--
1.7.3.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-13 12:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-13 12:45 [PATCH] ext4: reduce redundant check of '*options' Simon Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox