* [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.
@ 2011-03-07 23:26 Manoj Iyer
2011-03-07 23:26 ` Manoj Iyer
2011-03-08 0:43 ` Henrique de Moraes Holschuh
0 siblings, 2 replies; 6+ messages in thread
From: Manoj Iyer @ 2011-03-07 23:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Henrique de Moraes Holschuh
Please consider the following patch that adds support for auto loading
thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set
to LEN0068 instead of IBM0068.
==== dsdt.dsl =============================================
Device (HKEY)
{
Name (_HID, EisaId ("LEN0068"))
Method (_STA, 0, NotSerialized)
{
Return (0x0F)
}
============================================================
This patch was tested on a Lenovo x120e.
Thank you
Manoj Iyer
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads. 2011-03-07 23:26 [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads Manoj Iyer @ 2011-03-07 23:26 ` Manoj Iyer 2011-03-08 12:35 ` Henrique de Moraes Holschuh 2011-03-08 0:43 ` Henrique de Moraes Holschuh 1 sibling, 1 reply; 6+ messages in thread From: Manoj Iyer @ 2011-03-07 23:26 UTC (permalink / raw) To: linux-kernel; +Cc: Henrique de Moraes Holschuh The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead of IBM0068. Added new HID so that thinkpad_acpi module will auto load on these newer Lenovo ThinkPads. Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> --- drivers/platform/x86/thinkpad_acpi.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index eb99223..125d891 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -128,7 +128,8 @@ enum { }; /* ACPI HIDs */ -#define TPACPI_ACPI_HKEY_HID "IBM0068" +#define TPACPI_ACPI_IBM_HKEY_HID "IBM0068" +#define TPACPI_ACPI_LENOVO_HKEY_HID "LEN0068" #define TPACPI_ACPI_EC_HID "PNP0C09" /* Input IDs */ @@ -3879,7 +3880,8 @@ errexit: } static const struct acpi_device_id ibm_htk_device_ids[] = { - {TPACPI_ACPI_HKEY_HID, 0}, + {TPACPI_ACPI_IBM_HKEY_HID, 0}, + {TPACPI_ACPI_LENOVO_HKEY_HID, 0}, {"", 0}, }; -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads. 2011-03-07 23:26 ` Manoj Iyer @ 2011-03-08 12:35 ` Henrique de Moraes Holschuh 2011-03-18 18:09 ` Manoj Iyer 0 siblings, 1 reply; 6+ messages in thread From: Henrique de Moraes Holschuh @ 2011-03-08 12:35 UTC (permalink / raw) To: Manoj Iyer; +Cc: linux-kernel On Mon, 07 Mar 2011, Manoj Iyer wrote: > The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead > of IBM0068. Added new HID so that thinkpad_acpi module will > auto load on these newer Lenovo ThinkPads. > > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index eb99223..125d891 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -128,7 +128,8 @@ enum { > }; > > /* ACPI HIDs */ > -#define TPACPI_ACPI_HKEY_HID "IBM0068" > +#define TPACPI_ACPI_IBM_HKEY_HID "IBM0068" > +#define TPACPI_ACPI_LENOVO_HKEY_HID "LEN0068" > #define TPACPI_ACPI_EC_HID "PNP0C09" > > /* Input IDs */ > @@ -3879,7 +3880,8 @@ errexit: > } > > static const struct acpi_device_id ibm_htk_device_ids[] = { > - {TPACPI_ACPI_HKEY_HID, 0}, > + {TPACPI_ACPI_IBM_HKEY_HID, 0}, > + {TPACPI_ACPI_LENOVO_HKEY_HID, 0}, > {"", 0}, > }; -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads. 2011-03-08 12:35 ` Henrique de Moraes Holschuh @ 2011-03-18 18:09 ` Manoj Iyer 0 siblings, 0 replies; 6+ messages in thread From: Manoj Iyer @ 2011-03-18 18:09 UTC (permalink / raw) To: Henrique de Moraes Holschuh; +Cc: linux-kernel Henrique, Thanks the ack on the patch, any idea when this will be Q'ed for linus tree ? ----------------------------------------------------- Manoj Iyer Ubuntu/Canonical Hardware Enablement Team ------------------------------------------------------ On Tue, Mar 8, 2011 at 6:35 AM, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote: > On Mon, 07 Mar 2011, Manoj Iyer wrote: >> The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead >> of IBM0068. Added new HID so that thinkpad_acpi module will >> auto load on these newer Lenovo ThinkPads. >> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > > Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> > >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c >> index eb99223..125d891 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -128,7 +128,8 @@ enum { >> }; >> >> /* ACPI HIDs */ >> -#define TPACPI_ACPI_HKEY_HID "IBM0068" >> +#define TPACPI_ACPI_IBM_HKEY_HID "IBM0068" >> +#define TPACPI_ACPI_LENOVO_HKEY_HID "LEN0068" >> #define TPACPI_ACPI_EC_HID "PNP0C09" >> >> /* Input IDs */ >> @@ -3879,7 +3880,8 @@ errexit: >> } >> >> static const struct acpi_device_id ibm_htk_device_ids[] = { >> - {TPACPI_ACPI_HKEY_HID, 0}, >> + {TPACPI_ACPI_IBM_HKEY_HID, 0}, >> + {TPACPI_ACPI_LENOVO_HKEY_HID, 0}, >> {"", 0}, >> }; > > -- > "One disk to rule them all, One disk to find them. One disk to bring > them all and in the darkness grind them. In the Land of Redmond > where the shadows lie." -- The Silicon Valley Tarot > Henrique Holschuh > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads. 2011-03-07 23:26 [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads Manoj Iyer 2011-03-07 23:26 ` Manoj Iyer @ 2011-03-08 0:43 ` Henrique de Moraes Holschuh 2011-03-08 1:23 ` Manoj Iyer 1 sibling, 1 reply; 6+ messages in thread From: Henrique de Moraes Holschuh @ 2011-03-08 0:43 UTC (permalink / raw) To: Manoj Iyer; +Cc: linux-kernel On Mon, 07 Mar 2011, Manoj Iyer wrote: > Please consider the following patch that adds support for auto loading > thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set > to LEN0068 instead of IBM0068. Does the driver do anything useful on these Lenovo thinkpads? -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads. 2011-03-08 0:43 ` Henrique de Moraes Holschuh @ 2011-03-08 1:23 ` Manoj Iyer 0 siblings, 0 replies; 6+ messages in thread From: Manoj Iyer @ 2011-03-08 1:23 UTC (permalink / raw) To: Henrique de Moraes Holschuh; +Cc: linux-kernel Absolutely, it enables hotkeys on a host of new Lenovo thinkpads, x120e, T420, T520 etc. ----------------------------------------------------- Manoj Iyer Ubuntu/Canonical Hardware Enablement Team ------------------------------------------------------ On Mon, Mar 7, 2011 at 6:43 PM, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote: > On Mon, 07 Mar 2011, Manoj Iyer wrote: >> Please consider the following patch that adds support for auto loading >> thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set >> to LEN0068 instead of IBM0068. > > Does the driver do anything useful on these Lenovo thinkpads? > > -- > "One disk to rule them all, One disk to find them. One disk to bring > them all and in the darkness grind them. In the Land of Redmond > where the shadows lie." -- The Silicon Valley Tarot > Henrique Holschuh > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-18 18:09 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-07 23:26 [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads Manoj Iyer 2011-03-07 23:26 ` Manoj Iyer 2011-03-08 12:35 ` Henrique de Moraes Holschuh 2011-03-18 18:09 ` Manoj Iyer 2011-03-08 0:43 ` Henrique de Moraes Holschuh 2011-03-08 1:23 ` Manoj Iyer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox