* [PATCH] regulator: fix tps6524x section mismatch
@ 2011-03-24 20:30 Randy Dunlap
2011-03-25 0:14 ` Mark Brown
2011-03-26 14:08 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2011-03-24 20:30 UTC (permalink / raw)
To: lkml; +Cc: Liam Girdwood, Mark Brown, Cyril Chemparathy, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix section mismatch that is caused by init code calling exit code:
pmic_remove() cannot be marked as __devexit.
WARNING: drivers/regulator/tps6524x-regulator.o(.devinit.text+0x205): Section mismatch in reference from the function pmic_probe() to the function .devexit.text:pmic_remove()
The function __devinit pmic_probe() references
a function __devexit pmic_remove().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
pmic_remove() so it may be used outside an exit section.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Cyril Chemparathy <cyril@ti.com>
---
drivers/regulator/tps6524x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.38-git13.orig/drivers/regulator/tps6524x-regulator.c
+++ linux-2.6.38-git13/drivers/regulator/tps6524x-regulator.c
@@ -596,7 +596,7 @@ static struct regulator_ops regulator_op
.get_current_limit = get_current_limit,
};
-static int __devexit pmic_remove(struct spi_device *spi)
+static int pmic_remove(struct spi_device *spi)
{
struct tps6524x *hw = spi_get_drvdata(spi);
int i;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: fix tps6524x section mismatch
2011-03-24 20:30 [PATCH] regulator: fix tps6524x section mismatch Randy Dunlap
@ 2011-03-25 0:14 ` Mark Brown
2011-03-26 14:08 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-03-25 0:14 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, Liam Girdwood, Cyril Chemparathy, akpm
On Thu, Mar 24, 2011 at 01:30:59PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix section mismatch that is caused by init code calling exit code:
> pmic_remove() cannot be marked as __devexit.
>
> WARNING: drivers/regulator/tps6524x-regulator.o(.devinit.text+0x205): Section mismatch in reference from the function pmic_probe() to the function .devexit.text:pmic_remove()
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: fix tps6524x section mismatch
2011-03-24 20:30 [PATCH] regulator: fix tps6524x section mismatch Randy Dunlap
2011-03-25 0:14 ` Mark Brown
@ 2011-03-26 14:08 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-03-26 14:08 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, Mark Brown, Cyril Chemparathy, akpm
On Thu, 2011-03-24 at 13:30 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix section mismatch that is caused by init code calling exit code:
> pmic_remove() cannot be marked as __devexit.
>
> WARNING: drivers/regulator/tps6524x-regulator.o(.devinit.text+0x205): Section mismatch in reference from the function pmic_probe() to the function .devexit.text:pmic_remove()
> The function __devinit pmic_probe() references
> a function __devexit pmic_remove().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __devexit annotation of
> pmic_remove() so it may be used outside an exit section.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Cyril Chemparathy <cyril@ti.com>
> ---
> drivers/regulator/tps6524x-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-26 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 20:30 [PATCH] regulator: fix tps6524x section mismatch Randy Dunlap
2011-03-25 0:14 ` Mark Brown
2011-03-26 14:08 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox