* [PATCH] gpio: pca953x: Use handle_simple_irq instead of handle_edge_irq
@ 2011-04-26 12:28 Erik Botö
0 siblings, 0 replies; only message in thread
From: Erik Botö @ 2011-04-26 12:28 UTC (permalink / raw)
To: linux-kernel; +Cc: Grant Likely
Make pca953x driver use the simple irq handler since no hardware control
is necessary and the driver lacks an irq_ack function. handle_edge_irq()
calls chip->irq_ack() which crashes since this function does not exist.
Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index 7630ab7..78a8439 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -397,7 +397,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
irq_set_chip_data(irq, chip);
irq_set_chip_and_handler(irq, &pca953x_irq_chip,
- handle_edge_irq);
+ handle_simple_irq);
#ifdef CONFIG_ARM
set_irq_flags(irq, IRQF_VALID);
#else
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-04-26 12:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-26 12:28 [PATCH] gpio: pca953x: Use handle_simple_irq instead of handle_edge_irq Erik Botö
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox