The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH 0/4] Consolidate i8253 clocksource
@ 2011-05-09 13:27 Russell King - ARM Linux
  2011-05-09 23:29 ` John Stultz
  0 siblings, 1 reply; 2+ messages in thread
From: Russell King - ARM Linux @ 2011-05-09 13:27 UTC (permalink / raw)
  To: LKML, Thomas Gleixner, John Stultz
  Cc: H. Peter Anvin, Ingo Molnar, Ralf Baechle

Three architectures have an i8253 PIT clocksource, and each duplicates
the code for this.  The initial patch extracts a common implementation
to drivers/clocksource, and subsequent patches convert each architecture
to use this copy.

 arch/arm/include/asm/i8253.h         |   15 ++++++
 arch/arm/mach-footbridge/Kconfig     |    2 +
 arch/arm/mach-footbridge/isa-timer.c |   45 ++----------------
 arch/mips/Kconfig                    |    1 +
 arch/mips/include/asm/i8253.h        |    5 ++
 arch/mips/kernel/i8253.c             |   78 +-----------------------------
 arch/x86/Kconfig                     |    1 +
 arch/x86/include/asm/i8253.h         |    2 +
 arch/x86/kernel/i8253.c              |   79 +------------------------------
 drivers/clocksource/Kconfig          |    3 +
 drivers/clocksource/Makefile         |    1 +
 drivers/clocksource/i8253.c          |   88 ++++++++++++++++++++++++++++++++++
 include/linux/clocksource.h          |    2 +
 13 files changed, 126 insertions(+), 196 deletions(-)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/4] Consolidate i8253 clocksource
  2011-05-09 13:27 [PATCH 0/4] Consolidate i8253 clocksource Russell King - ARM Linux
@ 2011-05-09 23:29 ` John Stultz
  0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2011-05-09 23:29 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: LKML, Thomas Gleixner, H. Peter Anvin, Ingo Molnar, Ralf Baechle

On Mon, 2011-05-09 at 14:27 +0100, Russell King - ARM Linux wrote:
> Three architectures have an i8253 PIT clocksource, and each duplicates
> the code for this.  The initial patch extracts a common implementation
> to drivers/clocksource, and subsequent patches convert each architecture
> to use this copy.

Very cool! The series looks good to me. 

Although maybe should we get rid of the inb_p redefinitions in a later
cleanup? 

Acked-by: John Stultz <john.stultz@linaro.org>

thanks
-john



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-09 23:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-09 13:27 [PATCH 0/4] Consolidate i8253 clocksource Russell King - ARM Linux
2011-05-09 23:29 ` John Stultz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox