* [PATCH] staging: altera-stapl: dont cast void* from kmalloc()
@ 2011-08-13 9:34 Thomas Meyer
0 siblings, 0 replies; only message in thread
From: Thomas Meyer @ 2011-08-13 9:34 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, Linux Kernel Mailing List
From: Thomas Meyer <thomas@m3y3r.de>
Casting (void *) value returned by kmalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/staging/altera-stapl/altera.c b/drivers/staging/altera-stapl/altera.c
--- a/drivers/staging/altera-stapl/altera.c 2011-07-28 15:32:17.809920700 +0200
+++ b/drivers/staging/altera-stapl/altera.c 2011-08-01 19:58:10.467052822 +0200
@@ -2384,7 +2384,7 @@ static int altera_get_act_info(u8 *p,
act_proc_attribute =
(p[proc_table + (13 * act_proc_id) + 8] & 0x03);
- procptr = (struct altera_procinfo *)
+ procptr =
kzalloc(sizeof(struct altera_procinfo),
GFP_KERNEL);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-08-13 14:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-13 9:34 [PATCH] staging: altera-stapl: dont cast void* from kmalloc() Thomas Meyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).